Critical Nukes

[janusd]

Getting reports over on PEQ that spell criticals for non-evocation based spells aren't happening. Evocation based spells are still critting just fine, but for some reason spells based on say alteration or conjuration are not critting.

[So_1337]

That could explain the lack of critical heals from lifetaps (alteration based). Though that's more to do with Theft of Life (improved healing chance) than Fury of Magic (improved critical damage chance, which also improves healing from lifetaps as a result), I would imagine. Still, it's a place to look.

Thanks, JD.

[janusd]

Actually I think my lifetaps ARE crit-healing. I'll run in-game and start tapping away to watch the crit heals and get back with ya on that one.

[So_1337]

Okay, could be just the critical damage portion that isn't working. Was going off what I read in this post (http://www.projecteq.net/phpBB2/viewtopic.php?p=24381#24381):

Critical Affliction still doesn't work.
I suspect critical affliction prevents the Theft of Life ability from working too.

[trevius]

Denivia posted a suggested fix on my forums for Lifetaps not doing Crit Damage:

http://stormhavenserver.com/forums/viewtopic.php?f=16&t=505

effects.cpp
Change line 148

from
if(tt == ST_Target || tt == ST_Summoned || tt == ST_Undead) {


to
if(tt == ST_Target || tt == ST_Tap || tt == ST_Summoned || tt == ST_Undead) {

Looks like a good fix to me.

[janusd]

Just a note, Theft of Life does indeed work.