EQYali
08-19-2002, 05:21 AM
Hi all,
I am new here :)
I have get the last beta source last week and have a look on it.
I wanna give a little help if i can...
I have seen some strange thing in the attack.cpp (i thing dev team know already about that) :
* near line 102 : in the method Client::Attack
piercing attack is matching wind_instrument skill
the value skillinuse 0x36 match wind instrument, 0x24 is the good value
same thing for 2h piercing
skillinuse = 0x24 is the good value
(better put skillinuse = PIERCING; // as explain letter)
* near line 479 : in the NPC:Attack
skillinuse for 1h slash,1h blunt, piercing... doesn't match with the "skills.h"
something wrong or skill for NPC is different ?
* near line 558 : in the NPC:Attack
if (GetEquipment(7) && GetEquipment(8) && GetEquipment(7) && CanThisClassDuelWield ())
GetEquipment(7) appear two times
if (GetEquipment(7) && GetEquipment(8) && CanThisClassDuelWield ())
look better
* about skills :
i thing use skill name defined in the skills.h instead of hex value is better.
Nothing to change to the ".cpp" source after that if skills value is modified; only the ".h" is modified.
Yali
I am new here :)
I have get the last beta source last week and have a look on it.
I wanna give a little help if i can...
I have seen some strange thing in the attack.cpp (i thing dev team know already about that) :
* near line 102 : in the method Client::Attack
piercing attack is matching wind_instrument skill
the value skillinuse 0x36 match wind instrument, 0x24 is the good value
same thing for 2h piercing
skillinuse = 0x24 is the good value
(better put skillinuse = PIERCING; // as explain letter)
* near line 479 : in the NPC:Attack
skillinuse for 1h slash,1h blunt, piercing... doesn't match with the "skills.h"
something wrong or skill for NPC is different ?
* near line 558 : in the NPC:Attack
if (GetEquipment(7) && GetEquipment(8) && GetEquipment(7) && CanThisClassDuelWield ())
GetEquipment(7) appear two times
if (GetEquipment(7) && GetEquipment(8) && CanThisClassDuelWield ())
look better
* about skills :
i thing use skill name defined in the skills.h instead of hex value is better.
Nothing to change to the ".cpp" source after that if skills value is modified; only the ".h" is modified.
Yali