NPCs adding elemental and bane dmg twice?

[EvoZak]

Regarding the combat calculations for NPCs, it looks as if the bane and elemental damage is getting accumulated twice... or I'm confused :)

In checks to GetWeaponDamage(), the returned damage has elem and bane included. There are comments later that for NPCs, bane/elem dmg needs to be added since it wasn't earlier. But it was.

Noticed this and thought someone may appreciate the heads up. Or like I said, I'm just confused, but it looks like that's what is going on.

[ChaosSlayerZ]

Regarding the combat calculations for NPCs, it looks as if the bane and elemental damage is getting accumulated twice... or I'm confused :)

In checks to GetWeaponDamage(), the returned damage has elem and bane included. There are comments later that for NPCs, bane/elem dmg needs to be added since it wasn't earlier. But it was.

Noticed this and thought someone may appreciate the heads up. Or like I said, I'm just confused, but it looks like that's what is going on.

I have reported this like back in May and I was told it was since long fixed. After R535

[trevius]

Yeah, we fixed that quite a while ago. Try to make sure you are running the latest source if you are going to report bugs, please.

[EvoZak]

I'm updated to latest version out of SVN. However, like always, after posting in a forum and looking at it again I don't think it's a bug. Just sorta opaque code IMO.

The first calc adds the elem & bane dmg for POTENTIAL dmg. Later the min & max damage is augmented with the elem & bane damage for a range of the actual damage done.

So no bug, and no harm done by my uninformed posting. Perhaps someone else that is thinking the same thing will find this.

[trevius]

Maybe if you post the code you are referring to, it will be easier to see what you are talking about. I know that KLS and I worked on some issues with Bane and Elemental damage a couple of months ago that was adding Double (and then some) to the calculations. That particular issue has been resolved, but maybe there is still a problem somewhere else?

[EvoZak]

You misunderstand... there is no bug. And hence, no code posting. I was simply trying to describe what is going on with the calcs and why I thought there might have been a bug.