Bard instruments are not working on my server at all.

[Drakiyth]

I'm currently in the creation process of making bard paths on my server but I noticed the instrument testing is a complete failure right now. I've tried SoF client and HoT and not a thing is working right. The instruments simply don't increase the bard's songs at all. I'm starting to wonder if I didn't update a certain file within my database, but I haven't had any problems besides this.

If I can't get the instruments to work I'll improvise by going into the songs and making all of them about five times stronger naturally, which honestly wouldn't be that bad with how my server works, but I would rather fix this problem first.

Any help here?

[trevius]

I think they should be working. Maybe they just aren't showing up on the client properly. Have you tried checking #mystats or #myskills to see if the server is seeing something different than what the client is showing when using an instrument mod?

[Drakiyth]

I think they should be working. Maybe they just aren't showing up on the client properly. Have you tried checking #mystats or #myskills to see if the server is seeing something different than what the client is showing when using an instrument mod?

I just did a test with chords of dissonance and a normal lute. 2.0. Which should double the damage of the spell.

I cast while singing.. does 7 damage.. I have lute equipped 7 damage.

My #showstats is displaying my character has 20 stringed but the damage of the spell is not jumping to 14 as it should. Tried this with brass song as well and nothing.


EDIT:

okay, I just did a test with selos and it appears to be working with the drum.. Why aren't the damage spells working? How odd.

[Drakiyth]

After a series of testing it appears the only songs that are not effected are PBAOE spells. That's fine, I went into the spells and fixed all of them to be much stronger and made them singing so nobody has to worry about instruments not enhancing anything.

All of the other bard types are working fine, so this will do and the class is very balanced now.

Thanks for the help, hopefully a fix on the PBAOE spells will be added sometime.
I guess it isn't really a biggie though since there were only like 10 spells to fix.

[lerxst2112]

Do instrument mods affect those spells on live? If not, then you know why they don't on eqemu.

[AudioGarden21]

Do instrument mods affect those spells on live? If not, then you know why they don't on eqemu.

They absolutely do affect them on live.

[lerxst2112]

Looking at chords of dissonance which uses spell effect 334, I believe this is the problem.

From spell_effects.cpp:

case SE_BardAEDot:
{
effect_value = CalcSpellEffectValue(spell_id, i, caster_level);


Since the caster isn't passed in the instrument mods aren't calculated or used.

[sorvani]

where are you seeing that line? Because I don't see it in the current rev.

[trevius]

It is here:

http://code.google.com/p/projecteqemu/source/search?q=SE_BardAEDot&origq=SE_BardAEDot&btnG=Search+Trunk

Click the one at line 2947 of spell_effects.cpp.

[sorvani]

I'm still missing something. because
void Mob::DoBuffTic(int16 spell_id, int32 ticsremaining, int8 caster_level, Mob* caster) {
contains caster_level and caster, are we meaning they are not passed in to here from where dobufftic is called?

[Secrets]

I'm still missing something. because
void Mob::DoBuffTic(int16 spell_id, int32 ticsremaining, int8 caster_level, Mob* caster) {
contains caster_level and caster, are we meaning they are not passed in to here from where dobufftic is called?

We only pass the caster level currently. We'd need the rest of the mob object *OR* create a seperate function for determining bard calculations. Since all we do is pass the level, and not the instrument in question, we would need the client's inventory, and at that point it's just easier to pass a mob object.

[lerxst2112]

Changing it to:

effect_value = CalcSpellEffectValue(spell_id, i, caster_level, caster);

Should allow the mods to apply. I'm not a bard person, so I wouldn't know how to test it correctly.

[sorvani]

yeah completely missed that. I feel smart! I'll test it out. Rebuilding my server now.

[Optimus]

Any report if this change worked or not?

[sorvani]

Sorry, thought I committed that. It is in rev 2134.