Problem with revision 2136

[chrsschb]

Since updating to the newest revision I've started having issues with player pets stealing experience. If the pet does 51% of the total damage (or more) it takes 100% of the experience. This should only happen if the pet does 100% of the damage.

Any advice?

[chrsschb]

Bump, this is a pretty big issue for me. Player's who play pet classes have just about stopped playing until this is resolved, especially mages with epic pets. It's near impossible to out damage the pet while still playing efficiently.

[louis1016]

thats how it was on live years ago i dont know if it ever changed

[chrsschb]

I stated in my original post how it WAS and how it's SUPPOSED to be. This change happened recently and I'm assuming it's a source change as that's all that has changed on my server.

If the player does 1 damage, the pet should take 0 experience. This was put into effect nearly 12 years ago.

[lerxst2112]

Are you using bots as well or not?

If you are I'd guess this is the problem in NPC::Death()


#ifdef BOTS
if(!ownerInGroup) {
give_exp = NULL;
}
#endif //BOTS


I didn't debug it, but I assume that if the pet is the top damage on the hate list that it clears who to give experience to if they are not in a group. There's needs to be more checking to make sure it's actually a bot that was top damage and not a client's pet.

[chrsschb]

Are you using bots as well or not?

If you are I'd guess this is the problem in NPC::Death()


#ifdef BOTS
if(!ownerInGroup) {
give_exp = NULL;
}
#endif //BOTS


I didn't debug it, but I assume that if the pet is the top damage on the hate list that it clears who to give experience to if they are not in a group. There's needs to be more checking to make sure it's actually a bot that was top damage and not a client's pet.

Yeah I use bots for testing purposes on the server. Bots aren't being used when this is happening though.

[lerxst2112]

It doesn't matter. If you compiled for bots then that code is active.

[chrsschb]

Alright, guess I'll switch to a non-bot source until that's fixed.

Thanks for the help.

[bad_captain]

This should be fixed with the latest rev.

[chrsschb]

This should be fixed with the latest rev.

Awesome thanks man.