Fix: Low level damage cap

[jsr]

Server rules for lower level melee damage caps aren't working as intended.

In attack.cpp.client::attack;

I think this:

if(GetLevel() < 10 && max_hit > 20)
max_hit = (RuleI(Combat, HitCapPre10));
else if(GetLevel() < 20 && max_hit > 40)
max_hit = (RuleI(Combat, HitCapPre20));


Should be more like this:


if(GetLevel() < 10 && max_hit > RuleI(Combat, HitCapPre10))
max_hit = (RuleI(Combat, HitCapPre10));
else if(GetLevel() < 20 && max_hit > RuleI(Combat, HitCapPre20))
max_hit = (RuleI(Combat, HitCapPre20));


Not sure if it's efficient to use a variable instead for the rule value.

[Drajor]

Without looking at the code for getting rule values, I would use a few static const variables in this instance. Assuming you do not need to update these values during run-time.

[jsr]

I removed the code altogether for my purposes :)

[Drajor]

Haha me too!

[Akkadius]

Kind of dumb to replace a dynamic rule that you can change yourself in the rules table then to change code with a static value.

You can set the values of those rules in the `rules_values` table.

[Drajor]

I meant read the value from the DB into a static const.

[jsr]

Hi Akkadius,

Not sure if you realised from my original post, but with the current code, if you change the pre-10 cap to 100, it will mean that if a player uses a 12 damage weapon and hit for 24, their max damage becomes the cap (100). The cap needs to be included in the if statement.

[Secrets]

I'll add this into SVN later. Good catch.

[lerxst2112]

Rules can be changed at runtime, so it probably would not be good to cache the value. Even if you did all you're saving is a function call and a lookup by index in a static array, so I'd say not worth worrying about at all.

[Tabasco]

I didn't realize this hadn't made it in yet.
http://www.eqemulator.org/forums/showthread.php?t=35541

[Secrets]

To be honest me either Tabasco. I recall you posting it ages ago D:

[lerxst2112]

It looks like part of it made it in, because Bots were changed as well where before they didn't use the rules at all, but not completely.