Language Skill Ups

[demonstar55]

Clients were not being updated when they got a skill up, this fixes it (no idea why it was the other way, this at least matches live now and works right)

Index: EQEmuServer/zone/client.cpp
================================================== =================
--- EQEmuServer/zone/client.cpp (revision 2493)
+++ EQEmuServer/zone/client.cpp (working copy)
@@ -2348,7 +2348,7 @@
Chance = (Chance * RuleI(Character, SkillUpModifier)/100);

if(MakeRandomFloat(0,100) < Chance) { // if they make the roll
- SetLanguageSkill(langid, LangSkill+1); // increase the language skill by 1
+ IncreaseLanguageSkill(langid); // increase the language skill by 1
_log(SKILLS__GAIN, "Language %d at value %d successfully gain with %.4f%%chance", langid, LangSkill, Chance);
}
else

[joligario]

Since SetLanguageSkill() doesn't update client, perhaps we should add it to that function.

EDIT: Interesting... looking at it, the two functions differ for the language skill - 25 vs. 26

[joligario]

Update: This is going in soon with some other fixes as well.

[demonstar55]

Also, while you're changing some stuff around here, on live you can totally master a language with just a merc in the group, so you should be able to skill yourself up, something we can't do on here.

[sorvani]

interesting, wonder if live always let you skill yourself up in a group and it was not noticed until mercs came out. Since prior to that if one person was spamming, usually someone else was too.

[demonstar55]

When I was playing live me and my friends would just each spam one language each (so different languages) and still get skill ups.

EDIT: I should clarify, I would also get skill ups with the language I was spamming

[joligario]

I remember leapfrogging, but never self-improving. That's an interesting thought.

[gibroni]

I dont belive you could self improve your language. me and wife would group up and skill each other up by spamming each other. i would learn language she spammed, and she would skill up language i spammed. never could you skill yourself up. unless that is something they changed in the last couple years.