Spellscale not work in Perl?

[NatedogEZ]

quest::modifynpcstat("spellscale",900);


I've done every other stat like this and they work just fine... (didn't try healscale actually)


Anyone else have problems with this? I've scaled all stats on an NPC.. but when it comes to spells it only takes the spellscale from the database value set for that NPC.


Side note... my source is up to date as well.

[Akkadius]

quest::modifynpcstat("spellscale",900);


I've done every other stat like this and they work just fine... (didn't try healscale actually)


Anyone else have problems with this? I've scaled all stats on an NPC.. but when it comes to spells it only takes the spellscale from the database value set for that NPC.


Side note... my source is up to date as well.

Not sure about the quest version without looking at the source.

This is what I used in my stuff the day I put it in:

$NPC->ModifyNPCStat("spellscale", $SD[$NPC->GetLevel()][$NTYPE][22] * $SZD{$zonesn}[$instanceversion][9]);
$NPC->ModifyNPCStat("healscale", $SD[$NPC->GetLevel()][$NTYPE][23] * $SZD{$zonesn}[$instanceversion][8]);

$NPC being the entity iteration of course, and then the 2nd argument is my stuff I'm passing to it to get my scaling.

[NatedogEZ]

Thank you Akkadius I will try using entity like that.

[NatedogEZ]

Hmm.. did what you said... maybe its an issue with the NPC.

I am trying to scale "Spellscale" on player pets.

I tried just scaling the pets spell damage with the database .. set it to 150 and still doesn't work.

Works for normal NPCs though...

I spawned the pet with #dbspawn 1315 (the pet as an NPC it works!)

The NPC as a Player PET the scaling DOES NOT work.

So I wasn't doing it wrong.. just seems to be a problem somewhere in the code for player pets maybe?

I'll have to check it later.

[NatedogEZ]

From Attack.cpp

if(other->IsNPC() && !other->IsPet())
{
float npcspellscale = other->CastToNPC()->GetSpellScale();
damage = ((float)damage * npcspellscale) / (float)100;
}


This makes spellscale NOT work for pets I am guessing.

Is this intended?

[NatedogEZ]

I edited that and it didn't help... still not sure why I can't spellscale Player pets. (database and quest don't work)

[ChaosSlayerZ]

stupid question - what IS a spellscale? what it suppose to do?

[NatedogEZ]

Scales how much damage an NPC will do with spells.

100 = Normal damage

50 = Half damage

150 = 50% more dmg.. ect ect

You can scale damage with Perl in a boss fight for example.

I am trying to figure out why spellscale doesn't work for pets.

[Akkadius]

It was originally intended to perform scaling on the fly through Perl scripts.

So one issue is making entirely new spell sets for NPC's (Fuck that).

Use a Cleric spell set and you can scale it for example, have it do 5x the damage if you wish (500) and you can reuse the same spellset.

healscale does the same thing but for only healing spells.

Natedog, pet is derived from mob so you may need to do a $mob->CastToNPC()->ModifyNPCStat("stuff", value);

Don't take my syntax as verbatim, you may want to check the reference sheet but that is how you would handle it for pets.

[ChaosSlayerZ]

got it ;)
how does it works with dots and debuffs? do those also get scaled?
non stat buffs? like SoW?

[Akkadius]

got it ;)
how does it works with dots and debuffs? do those also get scaled?
non stat buffs? like SoW?

They are only damage oriented scales, + or -, so DoT's, DD's (anything damage oriented) and healscale is obvious (HoT's, Direct Heals)

That covers like 80% of spells that can even make use of scaling, SoW is not a good example, buffs aren't really either because NPC's are like 1% impacted by a stat buff when it comes to scaling. However if you are going to get tricky with fights such as using charms or other fancy spells you are usually going to tie that into your fight specially.

[NatedogEZ]

One thing to note though Akkadius... spellscale on pets doesn't even work through the database.


Will try Casting it though. (Talking player pets btw)

[Akkadius]

One thing to note though Akkadius... spellscale on pets doesn't even work through the database.


Will try Casting it though. (Talking player pets btw)

Was never meant to for pets, but the Perl handling should work

[NatedogEZ]

The perl handling works... but the damage never scales. (For player pets that is) :(

[Akkadius]

The perl handling works... but the damage never scales. (For player pets that is) :(

Pet spells are handled in a different part of the code that those variables were not implemented most likely.

[Kayen]

$npc->SetSpellFocusDMG()
$npc->SetSpellFocusHeal()

These are alternative functions that I added prior to Akka's code (and will stack with the dbase spell scale)

They work fine.

100 = 100% focus ect

Negative values can be used to reduce spell damage or even cause spells to heal if under 100.

Will work on any NPC, pets included.

[NatedogEZ]

Neat I will give that a try for player pets!



That is exactly what I was looking for thanks Keyan!

Kind of weird for the other way of doing this excludes player pets =(

[Akkadius]

Well I just so happened to test this today and it does indeed work.

You just need to make sure you cast:

$CT was me getting my pet target, really this would affect any NPC I targeted

sub EVENT_TARGET_CHANGE{
if($client->GetAggroCount() == 0){
### Test Scaling ###
if($name eq "Akkasham"){
$CT = $client->GetTarget();
$CT->CastToNPC()->ModifyNPCStat("max_hp", "10000000");
$CT->CastToNPC()->SetHP($CT->GetMaxHP());
}
}
}

[NatedogEZ]

modifynpcstat works for sure on pets.. I already use it to mod ALL of their stats

except Spellscale / healscale

I use $npc->SetSpellFocusDMG() for the scaling of spell damage though.