PDA

View Full Version : Bots compile has a lot of errors


NatedogEZ
02-11-2014, 01:08 AM
Buddy of mine was trying to compile bots.. and told me there were a lot of errors, so I tested it myself and it was also broken.

This commit has broken code in it :(

https://github.com/EQEmu/Server/commit/ce4f4995b50aed36dc483dd863a120b82f59212f


There are a lot of undefined errors for "botlevel" and "botclass" in the focus effects... I also don't see any code for "GetBotFocusIncoming"

From bot.cpp

chance += target->GetBotFocusIncoming(BotfocusFcHealPctCritIncoming, SE_FcHealPctCritIncoming, this, spell_id);

demonstar55
02-11-2014, 01:14 AM
Looks like I didn't have bots enabled when I tested it out before the merge. poop.

NatedogEZ
02-11-2014, 01:18 AM
I was going through fixing the errors but then I noticed there is missing code for that GetBotFocusIncoming.. so I couldn't really fix something that isn't there :p

All good demon.. hopefully it gets fixed soon ;)

Kayen
02-11-2014, 08:53 PM
Sorry.

That was a find/replace error.

There shouldn't be a GetBotFocusIncoming

It should just be handled by Mob::GetFocusIncoming

There are a lot of undefined errors for "botlevel" and "botclass" in the focus effects
I don't really have much experience with bot code, thought that was the correct use for them based on the old code.

I'll work to compile this correctly.

Kayen
02-11-2014, 11:17 PM
Fixes have been submitted.

https://github.com/KayenEQ/Server/commit/7623770613ecfacb31d24ee6ea0d645126a32ff2