Merc Crash

[rencro]

Compiled source from 9-3-2014, enabling mercs causing instant zone.exe crash on win8. Traced to zone/zone.cpp


void Zone::LoadMercTemplates(){
.
.


Replaced this with void Zone::LoadMercTemplates(){ from zone.cpp date 6-14-14 (my last build, and version i fork off of) and everything is good.

Looks related to the latest changes, will try to look into troubleshooting, unless whomever pushed this sees anything stand out.

Thanks..

[demonstar55]

can you post the crash dump?

[rencro]

zone.exe!__report_gsfailure() Line 147 C
> zone.exe!Zone::LoadMercTemplates() Line 608 C++
00000007() Unknown
[Frames below may be incorrect and/or missing]
zone.exe!free(void * pBlock) Line 51 C
zone.exe!_SetEnvironmentVariableW@8() C++
zone.exe!_SetEnvironmentVariableW@8() C++
zone.exe!_SetEnvironmentVariableW@8() C++
zone.exe!__findnext32() Unknown
ntdll.dll!77716645() Unknown
ntdll.dll!776da201() Unknown

[lerxst2112]

Looks like something overwriting the stack.

[demonstar55]

I don't have mercs set up to work on my test box, can you try applying https://gist.github.com/mackal/a704734cfc950bed6037 ?

[rencro]

Yes, that works perfectly.

Thanks to you both!!!!

[demonstar55]

Yes, that works perfectly.

Thanks to you both!!!!

Thank you for testing it :)

This will make it's way upstream very soon