PDA

View Full Version : Git pull from 09/05/2014 problem with tradeskill returns.


Mortow
09-06-2014, 12:39 PM
I pulled and recompiled last night and now with the RoF client (haven't tested UF client yet) when you do a tradeskill combine and it is supposed to return multiple items (like your smithing hammer and the item you created) it is only returning the first item and eating the other. I will test this on UF client and update here.

It appears to be doing the same thing with quest hand-ins. You only get the first item back if you turn in the wrong items.

EDIT: This is only an issue in the RoF client. I looged in with the UF client and the missing items were on my cursor.

Secrets
09-06-2014, 01:33 PM
This is because the RoF client has issues with cursor depth presently. No fix as of yet :X

demonstar55
09-06-2014, 01:34 PM
In the mean time, you can probably yell at Uleat :P

Mortow
09-06-2014, 02:42 PM
Nope no yelling. Uleat fixed the stack in inventory on trade bug and Secrets fixed the augment removal and insertion in RoF. Thanks a bunch guys.

Secrets
09-06-2014, 02:44 PM
Nope no yelling. Uleat fixed the stack in inventory on trade bug and Secrets fixed the augment removal and insertion in RoF. Thanks a bunch guys.

As a temporary workaround you can camp/zone and the item will appear on the cursor slot until the queue is clear again.

Uleat
09-06-2014, 03:19 PM
Unfortunately..there's no easy fix for this...


We need to pass an index value to the RoF client translator that can be used in slot-to-struct translations.

There's currently not a free packet offset that we can use without unknown consequences.


The most correct way would be to add a Byte or Word into the server packet structure and assign the index to this position.

This, however, would require modifying every OpCode handler (both, RX and TX) to accept the new structure..even having to
create client encode translators for OpCodes that currently don't use one.


There are ways around it, and I believe Secrets mentioned one the other day. It's just a matter of how much work do you
really want to do with it...