Acount Rewards Crash Client (RoFII)

[dagulus2]

Not sure if this is specific to me or an issue with the client, but when I assign an Account_Reward to an account, it crashes the client upon logging in.

I only currently own the RoFII client, so am unable to test further.

[epilz]

I will test that feature on UF and other clients when I get home

[epilz]

It's crashing on my ROF2 and UF client.

[demonstar55]

Can you post a crash dump?

[dagulus2]

Dump Summary
------------
Dump File: debug.dmp : E:\EQEmu Client RoFII\Logs\debug.dmp
Last Write Time: 19/02/2015 03:18:50
Process Name: eqgame.exe : E:\EQEmu Client RoFII\eqgame.exe
Process Architecture: x86
Exception Code: 0xC0000005
Exception Information: The thread tried to read from or write to a virtual address for which it does not have the appropriate access.
Heap Information: Not Present

System Information
------------------
OS Version: 5.1.2600
CLR Version(s):

Modules
-------
Module Name Module Path Module Version
----------- ----------- --------------
eqgame.exe E:\EQEmu Client RoFII\eqgame.exe 0.0.0.0
ntdll.dll C:\Windows\SysWOW64\ntdll.dll 6.1.7601.18247
kernel32.dll C:\Windows\SysWOW64\kernel32.dll 6.1.7601.18409
KERNELBASE.dll C:\Windows\SysWOW64\KERNELBASE.dll 6.1.7601.18409
mss32.dll E:\EQEmu Client RoFII\mss32.dll 3.0.0.0
user32.dll C:\Windows\SysWOW64\user32.dll 6.1.7601.17514
gdi32.dll C:\Windows\SysWOW64\gdi32.dll 6.1.7601.18577
lpk.dll C:\Windows\SysWOW64\lpk.dll 6.1.7601.18177
usp10.dll C:\Windows\SysWOW64\usp10.dll 1.626.7601.18454
msvcrt.dll C:\Windows\SysWOW64\msvcrt.dll 7.0.7601.17744
advapi32.dll C:\Windows\SysWOW64\advapi32.dll 6.1.7601.18247
sechost.dll C:\Windows\SysWOW64\sechost.dll 6.1.7600.16385
rpcrt4.dll C:\Windows\SysWOW64\rpcrt4.dll 6.1.7601.18532
sspicli.dll C:\Windows\SysWOW64\sspicli.dll 6.1.7601.18637
CRYPTBASE.dll C:\Windows\SysWOW64\CRYPTBASE.dll 6.1.7600.16385
winmm.dll C:\Windows\System32\winmm.dll 6.1.7601.17514
wsock32.dll C:\Windows\System32\wsock32.dll 6.1.7600.16385
ws2_32.dll C:\Windows\SysWOW64\ws2_32.dll 6.1.7601.17514
nsi.dll C:\Windows\SysWOW64\nsi.dll 6.1.7600.16385
dinput8.dll C:\Windows\System32\dinput8.dll 6.1.7600.16385
d3dx9_30.dll C:\Windows\System32\d3dx9_30.dll 9.12.589.0
wininet.dll C:\Windows\SysWOW64\wininet.dll 11.0.9600.17496
api-ms-win-downlevel-user32-l1-1-0.dll C:\Windows\SysWOW64\api-ms-win-downlevel-user32-l1-1-0.dll 6.2.9200.16492
api-ms-win-downlevel-shlwapi-l1-1-0.dll C:\Windows\SysWOW64\api-ms-win-downlevel-shlwapi-l1-1-0.dll 6.2.9200.16492
shlwapi.dll C:\Windows\SysWOW64\shlwapi.dll 6.1.7601.17514
api-ms-win-downlevel-version-l1-1-0.dll C:\Windows\SysWOW64\api-ms-win-downlevel-version-l1-1-0.dll 6.2.9200.16492
version.dll C:\Windows\System32\version.dll 6.1.7600.16385
api-ms-win-downlevel-normaliz-l1-1-0.dll C:\Windows\SysWOW64\api-ms-win-downlevel-normaliz-l1-1-0.dll 6.2.9200.16492
normaliz.dll C:\Windows\SysWOW64\normaliz.dll 6.1.7600.16385
iertutil.dll C:\Windows\SysWOW64\iertutil.dll 11.0.9600.17496
api-ms-win-downlevel-advapi32-l1-1-0.dll C:\Windows\SysWOW64\api-ms-win-downlevel-advapi32-l1-1-0.dll 6.2.9200.16492
userenv.dll C:\Windows\SysWOW64\userenv.dll 6.1.7601.17514
profapi.dll C:\Windows\SysWOW64\profapi.dll 6.1.7600.16385
xul.dll E:\EQEmu Client RoFII\xul.dll 0.0.0.0
js3250.dll E:\EQEmu Client RoFII\js3250.dll 4.0.0.0
nspr4.dll E:\EQEmu Client RoFII\nspr4.dll 4.6.1.0
msvcr71.dll E:\EQEmu Client RoFII\msvcr71.dll 7.10.3052.4
plc4.dll E:\EQEmu Client RoFII\plc4.dll 4.6.1.0
plds4.dll E:\EQEmu Client RoFII\plds4.dll 4.6.1.0
shell32.dll C:\Windows\SysWOW64\shell32.dll 6.1.7601.18517
ole32.dll C:\Windows\SysWOW64\ole32.dll 6.1.7601.17514
winspool.drv C:\Windows\System32\winspool.drv 6.1.7601.17514
comdlg32.dll C:\Windows\SysWOW64\comdlg32.dll 6.1.7601.17514
comctl32.dll C:\Windows\winsxs\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.7601.18201_none_ec8 0f00e8593ece5\comctl32.dll 5.82.7601.18201
steam_api.dll E:\EQEmu Client RoFII\steam_api.dll 1.14.66.23
imm32.dll C:\Windows\SysWOW64\imm32.dll 6.1.7601.17514
msctf.dll C:\Windows\SysWOW64\msctf.dll 6.1.7600.16385
apphelp.dll C:\Windows\System32\apphelp.dll 6.1.7601.17514
AcLayers.dll C:\Windows\AppPatch\AcLayers.dll 6.1.7601.17974
oleaut32.dll C:\Windows\SysWOW64\oleaut32.dll 6.1.7601.18640
mpr.dll C:\Windows\System32\mpr.dll 6.1.7600.16385
AcGenral.dll C:\Windows\AppPatch\AcGenral.dll 6.1.7601.18128
uxtheme.dll C:\Windows\System32\uxtheme.dll 6.1.7600.16385
samcli.dll C:\Windows\System32\samcli.dll 6.1.7601.17514
msacm32.dll C:\Windows\System32\msacm32.dll 6.1.7600.16385
sfc.dll C:\Windows\System32\sfc.dll 6.1.7600.16385
sfc_os.dll C:\Windows\System32\sfc_os.dll 6.1.7600.16385
dwmapi.dll C:\Windows\System32\dwmapi.dll 6.1.7600.16385
setupapi.dll C:\Windows\SysWOW64\setupapi.dll 6.1.7601.17514
cfgmgr32.dll C:\Windows\SysWOW64\cfgmgr32.dll 6.1.7601.17621
devobj.dll C:\Windows\SysWOW64\devobj.dll 6.1.7601.17621
urlmon.dll C:\Windows\SysWOW64\urlmon.dll 11.0.9600.17496
api-ms-win-downlevel-ole32-l1-1-0.dll C:\Windows\SysWOW64\api-ms-win-downlevel-ole32-l1-1-0.dll 6.2.9200.16492
AcXtrnal.dll C:\Windows\AppPatch\AcXtrnal.dll 6.1.7600.16385
shunimpl.dll C:\Windows\System32\shunimpl.dll 6.1.7601.17514
SortServer2003Compat.dll C:\Windows\System32\SortServer2003Compat.dll 6.1.7600.16385
mswsock.dll C:\Windows\System32\mswsock.dll 6.1.7601.18254
wship6.dll C:\Windows\System32\wship6.dll 6.1.7600.16385
nphooks.dll C:\Program Files (x86)\NetRatingsNetSight\NetSight\meter4\nphooks.d ll 6.2.0.15
psapi.dll C:\Windows\SysWOW64\psapi.dll 6.1.7600.16385
ntmarta.dll C:\Windows\System32\ntmarta.dll 6.1.7600.16385
Wldap32.dll C:\Windows\SysWOW64\Wldap32.dll 6.1.7601.17514
nscore.dll C:\Program Files (x86)\NetRatingsNetSight\NetSight\meter4\nscore.dl l 6.2.0.15
EQGraphicsDX9.DLL E:\EQEmu Client RoFII\EQGraphicsDX9.DLL 0.0.0.0
d3d9.dll C:\Windows\System32\d3d9.dll 6.1.7601.17514
d3d8thk.dll C:\Windows\System32\d3d8thk.dll 6.1.7600.16385
dpvs.dll E:\EQEmu Client RoFII\dpvs.dll 0.0.0.0
atiu9pag.dll C:\Windows\System32\atiu9pag.dll 8.14.1.6210
communication.dll C:\Program Files (x86)\NetRatingsNetSight\NetSight\meter4\communica tion.dll 6.2.0.15
nsmmc.dll C:\Program Files (x86)\NetRatingsNetSight\NetSight\nsmmc.dll 6.2.0.15
hid.dll C:\Windows\System32\hid.dll 6.1.7600.16385
wintrust.dll C:\Windows\SysWOW64\wintrust.dll 6.1.7601.18205
crypt32.dll C:\Windows\SysWOW64\crypt32.dll 6.1.7601.18277
msasn1.dll C:\Windows\SysWOW64\msasn1.dll 6.1.7601.17514
WSHTCPIP.DLL C:\Windows\System32\WSHTCPIP.DLL 6.1.7600.16385
nlaapi.dll C:\Windows\System32\nlaapi.dll 6.1.7601.17761
NapiNSP.dll C:\Windows\System32\NapiNSP.dll 6.1.7600.16385
pnrpnsp.dll C:\Windows\System32\pnrpnsp.dll 6.1.7600.16385
dnsapi.dll C:\Windows\System32\dnsapi.dll 6.1.7601.17570
winrnr.dll C:\Windows\System32\winrnr.dll 6.1.7600.16385
IPHLPAPI.DLL C:\Windows\System32\IPHLPAPI.DLL 6.1.7601.17514
winnsi.dll C:\Windows\System32\winnsi.dll 6.1.7600.16385
FWPUCLNT.DLL C:\Windows\System32\FWPUCLNT.DLL 6.1.7601.18283
rasadhlp.dll C:\Windows\System32\rasadhlp.dll 6.1.7600.16385
mssmp3.asi E:\EQEmu Client RoFII\mssmp3.asi 3.0.0.0
mssvoice.asi E:\EQEmu Client RoFII\mssvoice.asi 3.0.0.0
mssa3d.m3d E:\EQEmu Client RoFII\mssa3d.m3d 3.0.0.0
mssds3d.m3d E:\EQEmu Client RoFII\mssds3d.m3d 3.0.0.0
mssdx7.m3d E:\EQEmu Client RoFII\mssdx7.m3d 3.0.0.0
msseax.m3d E:\EQEmu Client RoFII\msseax.m3d 3.0.0.0
mssrsx.m3d E:\EQEmu Client RoFII\mssrsx.m3d 3.0.0.0
msssoft.m3d E:\EQEmu Client RoFII\msssoft.m3d 3.0.0.0
mssdsp.flt E:\EQEmu Client RoFII\mssdsp.flt 3.0.0.0
MMDevAPI.dll C:\Windows\System32\MMDevAPI.dll 6.1.7601.17514
propsys.dll C:\Windows\System32\propsys.dll 7.0.7601.17514
wdmaud.drv C:\Windows\System32\wdmaud.drv 6.1.7601.17514
ksuser.dll C:\Windows\System32\ksuser.dll 6.1.7600.16385
avrt.dll C:\Windows\System32\avrt.dll 6.1.7600.16385
msacm32.drv C:\Windows\System32\msacm32.drv 6.1.7600.16385
midimap.dll C:\Windows\System32\midimap.dll 6.1.7600.16385
AudioSes.dll C:\Windows\System32\AudioSes.dll 6.1.7601.18619
clbcatq.dll C:\Windows\SysWOW64\clbcatq.dll 2001.12.8530.16385
dsound.dll C:\Windows\System32\dsound.dll 6.1.7600.16385
powrprof.dll C:\Windows\System32\powrprof.dll 6.1.7600.16385
aticfx32.dll C:\Windows\System32\aticfx32.dll 8.17.10.1077
atiumdag.dll C:\Windows\System32\atiumdag.dll 7.14.10.833
atiumdva.dll C:\Windows\System32\atiumdva.dll 8.14.10.308
cryptsp.dll C:\Windows\System32\cryptsp.dll 6.1.7600.16385
rsaenh.dll C:\Windows\System32\rsaenh.dll 6.1.7600.16385
comctl32.dll C:\Windows\winsxs\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.7601.17514_none_41e6 975e2bd6f2b2\comctl32.dll 6.10.7601.17514
dbghelp.dll E:\EQEmu Client RoFII\dbghelp.dll 6.8.4.0

[demonstar55]

Oh, right client crash :P

Looking at it, it looks like the packets have changed a lot and they were never adjusted for newer clients :P

[demonstar55]

https://i.imgur.com/QCoceJc.png just wanted to say I did get it to display for RoF2, although, claiming currently doesn't work :/

[demonstar55]

Hmm look at UF, it appears to work there, can you post the rewards you were using?

[epilz]

I just picked random items to try. Did get it to not crash on ROF2 once, but its not showing the rewards, but does say I have one

[demonstar55]

I didnt get any crashes, UF worked fine though. Need to try more things I guess (why I asked for some examples that were causing issues)

[epilz]

Just migrated my server from Windows 2012 to Ubuntu. Once I finish with security patches, and its back up, I will test again. Mainly the items I was adding were custom items that I have created. Going to try cloth hat like you did in the screenshot.

[epilz]

Tried again. Did not work. Here is pic of my claims window w/ message stating I have an account reward.

http://i.imgur.com/rVTwMrn.jpg

Other is DB pic showing the fields populated.

http://i.imgur.com/Kol1fVR.jpg

[demonstar55]

Yeah, that's not how the DB entries are done :P

describe veteran_reward_templates;
+-------------+----------------------+------+-----+---------+-------+
| Field | Type | Null | Key | Default | Extra |
+-------------+----------------------+------+-----+---------+-------+
| claim_id | int(10) unsigned | NO | PRI | NULL | |
| name | varchar(64) | NO | | NULL | |
| item_id | int(10) unsigned | NO | | NULL | |
| charges | smallint(5) unsigned | NO | | NULL | |
| reward_slot | tinyint(3) unsigned | NO | PRI | NULL | |
+-------------+----------------------+------+-----+---------+-------+

and

describe account_rewards;
+------------+------------------+------+-----+---------+-------+
| Field | Type | Null | Key | Default | Extra |
+------------+------------------+------+-----+---------+-------+
| account_id | int(10) unsigned | NO | PRI | NULL | |
| reward_id | int(10) unsigned | NO | PRI | NULL | |
| amount | int(10) unsigned | NO | | NULL | |
+------------+------------------+------+-----+---------+-------+

Entries I have

select * from veteran_reward_templates;
+----------+------------------+---------+---------+-------------+
| claim_id | name | item_id | charges | reward_slot |
+----------+------------------+---------+---------+-------------+
| 1 | Cloth Cap | 1001 | 1 | 0 |
| 2 | Tae Ew Hide Sack | 17123 | 1 | 0 |
| 2 | Cloth Cap | 1001 | 3 | 1 |
+----------+------------------+---------+---------+-------------+

select * from account_rewards;
+------------+-----------+--------+
| account_id | reward_id | amount |
+------------+-----------+--------+
| 70624 | 1 | 93 |
| 70624 | 2 | 1 |
+------------+-----------+--------+

[epilz]

Thanks for the info. I just started toying with it yesterday. I will test it out later tonight.

[dagulus2]

Mmmm, my setup is exactly the same as demonstar55's and its still crashing the client.

[epilz]

Tested and no crashes. UF does not give me error, just stuck on Sending your claims request to the server. ROF2 gives me the rejection error when trying to claim.

[demonstar55]

If its RoF/RoF2, that's because I haven't fixed them yet. Claiming rewards with multiple items doesn't work, haven't had time to figure it out yet.

[demonstar55]

Okay, it should work better for all clients now. There are a few things I need to investigate on live, but it should at least not crash RoF+ :P

[epilz]

Something has changed after the source update, for some reason, my ROF2 client crashes after character select. UF seems to work ok

[epilz]

Removed the claims assigned to my GM toon and ROF2 client got past character select and works fine now

[demonstar55]

If you post your reward you were crashing with I can try to get if so the source can fix the data, although, you should probably not enter bad data in the tables.

[epilz]

Used the same exact rewards that you posted above. I have removed them and I can login the client now. I did test UF client and it worked. I could get claim the cloth hat and it put it in my inventory after claiming

[demonstar55]

Are you sure you updated then?

[epilz]

yup, here is my changelog.

EQEMu Changelog (Started on Sept 24, 2003 15:50)
-------------------------------------------------------
== 02/20/2015 ==
demonstar55: Implement claims for RoF/RoF2 (should no longer crash the client!)
- fixed bugs related to claims for the rest of the clients (woo infinite loops)

== 02/18/2015 ==
Trevius: Fix for potential recursive loops if using RemoveFromHateList() within EVENT_HATE_LIST.

== 02/17/2015 ==
Uleat: Implemented per-client character creation limiting. Caps are unknown atm..so, don't get over-zealous!
Notes:
- Titanium is hard-coded to min/max of 8 in both the server and client translator code (client doesn't support variations in available character count)
- SoF thru RoF2 have had their max characters raised to 12 from 10
- Changing the number of characters per account is accomplished by:
1) Setting consts::CHARACTER_CREATION_LIMIT to the desired count in the client's constants file in ../common/patches/
2) Ensuring that eq_dictionary's EmuConstants::CHARACTER_CREATION_LIMIT is equal-greater than the client's new value..referencing is good
3) Recompiling the server code
- A rules-based qualifier may be added at some point

[dagulus2]

Rebuilt this morning and now it's all working nicely for RoFII - Good work!

[epilz]

After updating the source changes made late last night, problem is resolved. No more ROF2 crashes w/ rewards, and claims work fine now. Thanks Demon and Uleat