Natedog...

[kimura]

is a beast, just sayin...

Thanks for the bot fixes bro! You da man!

Not only did he fix and commit the bots crashing and HP/Stats issues, bots now benefit from item's focus effects AND Heroic stats, which they did not before...Good job bro!!

[Akkadius]

is a beast, just sayin...

Thanks for the bot fixes bro! You da man!

Not only did he fix and commit the bots crashing and HP/Stats issues, bots now benefit from item's focus effects AND Heroic stats, which they did not before...Good job bro!!

About time someone take ownership over bots. :grin:

[chrsschb]

Bots in a good place again? :D

[Kingly_Krab]

Bots in a good place again? :D
Yeah, he managed to increase their effectiveness quite a bit, as well as fixing some redundancies and errors, just take a look at today's commits (https://github.com/EQEmu/Server/commits/master).

[Burningsoul]

I just accidently all over the desk, that's great fugging news man, THANK YOU NATE.

[NatedogEZ]

They are not perfect... but I will continue to work through the crashes as I see them.

[Secrets]

someone give this man a dev title

[kimura]

^ in agreement

[atrayas]

someone give this man a dev title

I second this. Natedog has helped me and my team a ton over on Imperium. Guy deserves the recognition.

[rencro]

Still crashes on last bot members death.

Ex: Me and my single bot in a 2 person group, bot dies, CRASH.

Group's memory has already been deleted in this case once coming back from:


// delete from group data
RemoveBotFromGroup(this, g);


So when this gets processed:


// if group members exist below this one, move
// them all up one slot in the group list
int j = i+1;
for(; j<MAX_GROUP_MEMBERS; j++) {
if(g->members[j]) {
g->members[j-1] = g->members[j];
strcpy(g->membername[j-1], g->members[j]->GetCleanName());
g->membername[j][0] = '\0';
memset(g->membername[j], 0, 64);
g->members[j] = nullptr;
}
}


It crashes, as I mentioned, that memory is gone.

Looks like it just needed your change moved up in the code: as in


diff --git a/zone/bot.cpp b/zone/bot.cpp
index ebc5f47..f382272 100644
--- a/zone/bot.cpp
+++ b/zone/bot.cpp
@@ -5897,6 +5897,11 @@ bool Bot::Death(Mob *killerMob, int32 damage, uint16 spell_id, SkillUseTypes att
// delete from group data
RemoveBotFromGroup(this, g);

+ //Make sure group still exists if it doesnt they were already updated in RemoveBotFromGroup
+ g = GetGroup();
+ if (!g)
+ break;
+
// if group members exist below this one, move
// them all up one slot in the group list
int j = i+1;
@@ -5910,11 +5915,6 @@ bool Bot::Death(Mob *killerMob, int32 damage, uint16 spell_id, SkillUseTypes att
}
}

- //Make sure group still exists if it doesnt they were already updated in RemoveBotFromGroup
- g = GetGroup();
- if (!g)
- break;
-
// update the client group
EQApplicationPacket* outapp = new EQApplicationPacket(OP_GroupUpdate, sizeof(GroupJoin_Struct));
GroupJoin_Struct* gu = (GroupJoin_Struct*)outapp->pBuffer;


And then I dont crash in this situation.

Thanks..

[phantomghost]

When I am recompiling this it looks like the update files related to this were

bot.cpp
bot.h
questmgr.cpp

When I compile bot.cpp I get 10 errors related to setcurrentspeed.

Not sure what I missed or if I missed adding something, but I cannot get the compile to succeed.

[demonstar55]

Update your source again.

[Tyen05]

someone give this man a dev title

Night crew agrees with this