Spell Casting Mastery

[provocating]

Anyone know why SCM is checking against a random? I was under the understanding that it was a passive always on ability and should not be random.

https://github.com/EQEmu/Server/blob/master/zone/effects.cpp

I put some extra logging in the code so I can get a feel for what is going on and it is rather rare there are any spell savings at all.

if(SuccessChance <= (SpecializeSkill * 0.3 * bonus))
{
PercentManaReduction = 1 + 0.05f * SpecializeSkill;
switch(GetAA(aaSpellCastingMastery))
{
case 1:
PercentManaReduction += 2.5;
break;
case 2:
PercentManaReduction += 5.0;
break;
case 3:
PercentManaReduction += 10.0;
break;
}

switch(GetAA(aaAdvancedSpellCastingMastery))
{
case 1:
PercentManaReduction += 2.5;
break;
case 2:
PercentManaReduction += 5.0;
break;
case 3:
PercentManaReduction += 10.0;
break;
}
}

[Shendare]

Your understanding sounds the same as mine... SCM is a flat mana preservation effect applied to all spellcasts. Don't think it has anything to do with Specialization skills. Sounds like a matter of confusion when it was implemented.

[Shendare]

http://everquest.allakhazam.com/wiki/eq:Spell_Casting_Mastery

[provocating]

Ahh.....nevermind... I see, this explained it.

http://otherworlds31279.yuku.com/topic/1092/Spell-Casting-Mastery-the-best-archetype-AA-for-any-caster#.VaV3SkYgZ8E

[provocating]

http://everquest.allakhazam.com/wiki/eq:Spell_Casting_Mastery

LOL Shendare, when I started digging into it I was like "That is not how I understood it". That kind of blows if you think about it. You are not guaranteed a savings.

[demonstar55]

SPA 132 (what mana pres focus and SCM use) works by saving between base1 and base2 percent of the mana. I think this SPA needs to be looked at again and SCM shouldn't have any GetAA non-sense.

I also don't see anything in the AA data that says it shouldn't work as I described (which has no RNG since base1 and base2 are the same)