Get sitting state inside a spell script?

[N0ctrnl]

I've been working on the Yaulp V spell. It's supposed to fade on sitting, but the current code seems to only check against that during the first tick of the buff. Then the cleric can sit and the buff remains.

My first thought was just to throw a timer in when the spell hits, and check it over and over for sit state and whether the buff is on the character. If it is, drop it. The issue with that is, as I know now, that the spell quests don't seem to have access to the same functions - $client->IsSitting() in this case.

Does that sound about right? Is there any way at all the spell scripts can ascertain the sitting state of the client?

Thanks!

[ghanja]

It's a spell not a client script.

You'll want to get the mob entity (client in this case) using $caster_id

so think
my $client = $entitylist->GetClientByID($caster_id);

Then $client->IsSitting() may be available.

The screwiness may come because of the EVENT_TIMER sub.


I've been working on the Yaulp V spell. It's supposed to fade on sitting, but the current code seems to only check against that during the first tick of the buff. Then the cleric can sit and the buff remains.

My first thought was just to throw a timer in when the spell hits, and check it over and over for sit state and whether the buff is on the character. If it is, drop it. The issue with that is, as I know now, that the spell quests don't seem to have access to the same functions - $client->IsSitting() in this case.

Does that sound about right? Is there any way at all the spell scripts can ascertain the sitting state of the client?

Thanks!

[N0ctrnl]

Well, even checking/removing on buff tic would be way more than there is currently.

[N0ctrnl]

It's been a long while, but since I never posted how I actually did this, I figure it might be a good time to do that. :)

Here's the solution I came up with. Basically it runs a timer all the time for the PAL/CLR class and clears the Yaulp buffs (by ID) when those classes sit. It's probably not real efficient, but it does work.

In quests/global/global_player.pl


sub EVENT_ENTERZONE {
if($class eq "Cleric" || $class eq "Paladin") {
quest::settimer("yaulp",2);
}
}

sub EVENT_TIMER {
if ($timer eq "yaulp") {
quest::stoptimer("yaulp");
if ($client->IsSitting() && ($client->FindBuff(3186) || $client->FindBuff(2326) || $client->FindBuff(1534) || $client->FindBuff(210) || $client->FindBuff(44) || $client->FindBuff(43))) {
$client->BuffFadeBySpellID(3186);
$client->BuffFadeBySpellID(2326);
$client->BuffFadeBySpellID(1534);
$client->BuffFadeBySpellID(210);
$client->BuffFadeBySpellID(44);
$client->BuffFadeBySpellID(43);
}
quest::settimer("yaulp",1);
}
}

[demonstar55]

Better yet, remove the quest code since I fixed this.

[N0ctrnl]

Got a link to details anywhere in particular?

[demonstar55]

https://github.com/EQEmu/Server/commit/8400994c57c085379971a709e8c1dbade603316b#diff-4abb8f2b1b574caa5cd2b1de45af3a72

https://github.com/EQEmu/Server/commit/8400994c57c085379971a709e8c1dbade603316b#diff-f3535f22828f28a04255a136be5aa5bf

https://github.com/EQEmu/Server/commit/8400994c57c085379971a709e8c1dbade603316b#diff-49618e05fa3111014e202214f305d8fc