Major Crashes - Please help

[Mortykins]

Hi Folks,

Well so I believe it was about the same time I inputted the data in for the expeditions into global_player.pl that people are now crashing when zoning, and it actually crashes the whole zone but leaves no log files indicating what the crash is about. I've never been real super good as far as PERL goes so when I was going over the directions for the expedition system I may have misunderstood how and where to enter in the PERL parts for that to work..

On a side note the expeditions are working perfectly and would like to keep them but the zone crashes makes it rough.


Morty

[Akkadius]

The expedition code you are using is really old, but if you're getting crashes you should be producing a log of some sort.

[Mortykins]

Where do I get the newest version of that ? I would love to be using what is current maybe that will solve everything. There was some crash reports but I thought maybe they were related to something else.. If you have time to look at the crashes I put them up on my site in a zip file from today's reboot : www.raidaddicts.org/6-20-16.zip

Morty

[Akkadius]

I don't have the latest one publicly available because I have massively overhauled it for EZ.

You don't have any crashes related to expedition related stuff, it all looks combat/Bot/AI related.

on eqemu_update.pl, update it with option 20, then download the crash report script with option 15 and you can paste your crash summary so that it can be troubleshot.

You should also make sure that you are on the latest source before you get people troubleshooting your crashes for you.

[Mortykins]

Roger that I will work on updating and getting those reports , thanks for the assistance.

Morty

[Kingly_Krab]

My question is, how did you get out-of-date Expeditions code? Was it legacy stuff already in your server from a couple of months, maybe years ago?

[Mortykins]

Ok now that I have the new binaries, here is some crash reports :)

Kingly - Was on the EOC , some guide about expeditions


Ok now that I have the new binaries, here is some crash reports :)

Kingly - Was on the EOC , some guide about expeditions


Crash Occurrence 1 Time(s) Length (481)

c:\server\source\server\zone\bot.cpp (8162): Bot::GetNeedsCured
c:\server\source\server\zone\bot.cpp (7788): EntityList::Bot_AICheckCloseBeneficialSpells
c:\server\source\server\zone\botspellsai.cpp (1032): Bot::AI_IdleCastCheck
c:\server\source\server\zone\bot.cpp (2578): Bot::AI_Process
c:\server\source\server\zone\bot.cpp (1860): Bot::Process
c:\server\source\server\zone\entity.cpp (487): EntityList::MobProcess
c:\server\source\server\zone\net.cpp (497): main

=========================================
Crash Occurrence 1 Time(s) Length (847)

c:\server\source\server\zone\mob.cpp (4556): Mob::TrySpellOnKill
c:\server\source\server\zone\attack.cpp (2092): NPC::Death
c:\server\source\server\zone\attack.cpp (3149): Mob::CommonDamage
c:\server\source\server\zone\attack.cpp (1835): NPC::Damage
c:\server\source\server\zone\attack.cpp (2490): Mob::DamageShield
c:\server\source\server\zone\attack.cpp (3048): Mob::CommonDamage
c:\server\source\server\zone\attack.cpp (1265): Client::Damage
c:\server\source\server\zone\attack.cpp (1767): NPC::Attack
c:\server\source\server\zone\attack.cpp (4698): Mob::DoMainHandAttackRounds
c:\server\source\server\zone\mob_ai.cpp (1109): Mob::AI_Process
c:\server\source\server\zone\npc.cpp (741): NPC::Process
c:\server\source\server\zone\entity.cpp (487): EntityList::MobProcess
c:\server\source\server\zone\net.cpp (497): main

=========================================

[Uleat]

Second: https://github.com/EQEmu/Server/blob/master/zone/mob.cpp#L4556

If 'spellbonuses.SpellOnKill[i]' is greater than the max spell id, the dereference of spells[spellbonuses.SpellOnKill[i]] following it will cause an
"Exception Access Violation" error and crash the server.


First: Same with https://github.com/EQEmu/Server/blob/master/zone/bot.cpp#L8162

I think this has come up before..invalid deref on 'tar->GetBuffs()'

[Mortykins]

Think this has been resolved , ty Natedog :)

[NatedogEZ]

Certain AA spells were missing in his database... Killing Spree spell was missing and every time something was killed it try to cast the buff and crashed server it seemed.

[Uleat]

Out-of-scope:

That bot creation issue may be caused by enforced naming conventions..they're not exactly client-strict..but, a lot closer.

I'll look at that other issue..may just be missing a packet update - depending on where it is occurring.

[Kingly_Krab]

Well, his bots usually are just "playerName" + "sDPS" or something like that, so it could be the name being too long, being taken by someone who used that name before, or the code just acting weirdly. I've thought about writing a Perl plugin similar to the client Name Randomizer for use with bots.

[Uleat]

Here's the current way of checking: https://github.com/EQEmu/Server/blob/master/zone/bot.cpp#L1533


The old way had the 'check' coded..but, was using bad methodology...

https://github.com/EQEmu/Server/blob/747895cbe586879926322d95cd049a1f440d4e88/zone/bot.cpp#L1522

In addition to basically allowing any characters in the name, it only failed if the last character was !isalpha() or '_'

[Mortykins]

Some more crash's today

Crash Occurrence 1 Time(s) Length (481)

c:\server\source\server\zone\bot.cpp (8162): Bot::GetNeedsCured
c:\server\source\server\zone\bot.cpp (7788): EntityList::Bot_AICheckCloseBeneficialSpells
c:\server\source\server\zone\botspellsai.cpp (1032): Bot::AI_IdleCastCheck
c:\server\source\server\zone\bot.cpp (2578): Bot::AI_Process
c:\server\source\server\zone\bot.cpp (1860): Bot::Process
c:\server\source\server\zone\entity.cpp (487): EntityList::MobProcess
c:\server\source\server\zone\net.cpp (497): main

=========================================
Crash Occurrence 1 Time(s) Length (1364)

c:\server\source\server\zone\perl_mob.cpp (3843): XS_Mob_Message
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 2804A285)
2804A285 (perl512): (filename not available): Perl_find_runcv
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 280724C0)
280724C0 (perl512): (filename not available): Perl_runops_standard
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 2802A817)
2802A817 (perl512): (filename not available): Perl_call_pv
c:\server\source\server\zone\embparser.cpp (727): PerlembParser::SendCommands
c:\server\source\server\zone\embparser.cpp (215): PerlembParser::EventCommon
c:\server\source\server\zone\embparser.cpp (249): PerlembParser::EventGlobalPlayer
c:\server\source\server\zone\quest_parser_collecti on.cpp (349): QuestParserCollection::EventPlayerGlobal
c:\server\source\server\zone\quest_parser_collecti on.cpp (306): QuestParserCollection::EventPlayer
c:\server\source\server\zone\client.cpp (1042): Client::ChannelMessageReceived
c:\server\source\server\zone\client_packet.cpp (4139): Client::Handle_OP_ChannelMessage
c:\server\source\server\zone\client_packet.cpp (479): Client::HandlePacket
c:\server\source\server\zone\client_process.cpp (609): Client::Process
c:\server\source\server\zone\entity.cpp (487): EntityList::MobProcess
c:\server\source\server\zone\net.cpp (497): main

=========================================
Crash Occurrence 1 Time(s) Length (847)

c:\server\source\server\zone\mob.cpp (4556): Mob::TrySpellOnKill
c:\server\source\server\zone\attack.cpp (2092): NPC::Death
c:\server\source\server\zone\attack.cpp (3149): Mob::CommonDamage
c:\server\source\server\zone\attack.cpp (1835): NPC::Damage
c:\server\source\server\zone\attack.cpp (2490): Mob::DamageShield
c:\server\source\server\zone\attack.cpp (3048): Mob::CommonDamage
c:\server\source\server\zone\attack.cpp (1265): Client::Damage
c:\server\source\server\zone\attack.cpp (1767): NPC::Attack
c:\server\source\server\zone\attack.cpp (4698): Mob::DoMainHandAttackRounds
c:\server\source\server\zone\mob_ai.cpp (1109): Mob::AI_Process
c:\server\source\server\zone\npc.cpp (741): NPC::Process
c:\server\source\server\zone\entity.cpp (487): EntityList::MobProcess
c:\server\source\server\zone\net.cpp (497): main

=========================================