Merc Weapons not showing since last source update

[DanCanDo]

Just curious, merc primary/secondary haven't been showing up (displayed),
since I updated to the source that implemented ^sow cmd for bots.
Not sure if this is just a coincidence or not, anyone else having that prob ?

[Uleat]

Was the sow command the only change that you pulled in when this started occurring?

Or did you grab some from the last few days as well?

[DanCanDo]

Oh there was a few updates, probably 2 weeks or less worth I think.

[DanCanDo]

Actually, just checked on my own records, Oct 6th was last compile, so anything
added since then up until the ^sow commit

[Uleat]

I pushed and pulled some things regarding slots recently..I'll double-check tonight to see if I messed up a rename.

[DanCanDo]

Oh thank you, but on a side note, I just tried something and gave a weapon to my
merc and it showed up, haha so now I am stumped

[DanCanDo]

I did confirm through my test box here, since it still had a compile on it from Oct 7th.
The merc weps were showing fine, then I pulled fresh source updates (tonight) and
recompiled and the merc weps were not showing. I dismissed the old merc and bought
a new one just to make sure. For now, it's no big deal to me, I will just back date the
code I'm using on my public server so the players can have their merc weps :)

[Uleat]

Did you re-run shared_memory?


EDIT: I did run through the code changes in all but the client translators and didn't see any mis-namings.

[DanCanDo]

Yes I did, actually aside from it being set to run everytime I boot the server, I end up
running it occassionally, while I edit loot tables on the go.
I did revert the server back to the Oct 6th git pull code and the merc weapons are
showing up again. Here is another "coincidence" though, I had created some NPC's
for the Halloween instance, which I equipped them with swords, when I first started
working on it. The swords were not showing up on them either, until I reverted that
code back last night. I have no idea whether that's related to the merc issue, but as
I indicated, just a coincidence.

[Uleat]

Do me a favor the next time you have an opportunity to test this..

Use #npcstats and/or #npcloot show on the mob to verify that it has the actual item on it.

I know that would require using the newer code..so, don't go out of your way to test. Just, if you happen to be using the 'affected' code.


I'll go over those sections of code again - though, it could be an uncleared hotfix.

I did remove an ItemData field that I deprecated before full implementation due to it being an incorrect behavior model..and that throws off the item mmf alignment.

[DanCanDo]

Yes, I did #npcstats (which does show loot) and the NPC's do indeed show that sword.
The sword in the loot table is set to "Yes" for equipped and 100% chance.
I have both the newer and old binaries backed up, so switching back and forth with
a copy and paste only takes a few seconds :)

[DanCanDo]

Here's something that might help.
I had a git pull from Oct 14th that I never compiled until now just to test.
The merc and npc swords are showing up normally now.
So between there and 20th ? or 17th I think?

[Uleat]

And you're sure that you don't have an uncleared hotfix?

There is a change in there that will cause issues like this if shared_memory isn't run or a hotfix is left in place when run.


EDIT: I am reviewing the merc code atm..

[DanCanDo]

I have never used "hotfix" for anything. I always directly run the shared_memory
executable from the server folder. I use npcedit ingame as well as georges npceditor
to create npc's and adjust loot tables which after doing so each time, I run the
shared_memory (from the server folder).

[DanCanDo]

I was just thinking about something. That hotfix thing, I don't know too much about it,
as I said, I've never used it. There is a hotfix_name in the variables which has blank
values except for timestamp of 2015-10-22 01:15:54
The database I have is not that old though, I use one downloaded from the daily dump
back in May of this year.

[DanCanDo]

While we're on the on the topic of merc behaviour (chuckle)
I had one simple question. Is it normal for mercs to be able to zone in, or be created in
an instance zone? The instance I created on my server allows mercs (not my choice),
but I don't remember if that was something normal way back on live.
Edit: Just to clarify it is not a group or raid instance.

[demonstar55]

If you remember the last good commit, can you run git bisect to find the commit that introduced the error?

https://git-scm.com/docs/git-bisect

[Uleat]

I just committed a fix for an issue that was probably causing this..update and see if your problem goes away.

[DanCanDo]

I just committed a fix for an issue that was probably causing this..update and see if your problem goes away.

Eureka! Once again, your expertise have prevailed.
I pulled that update this afternoon and weps are showing up on the mercs.

Thank You so much Uleat :)

[Uleat]

Lol! Don't thank me so much..I broke it in the first place :P

[DanCanDo]

Is it safe to assume, that ^sow cmd update is still in the code (with todays pull) ?
The only reason I ask, on my public server it was reverted back to code from before
that for the merc weps, but if I run this on the server, then I can tell players the
new ^sow cmd is back ? (chuckle) "I can have my cake and eat it to" ? :)

[Uleat]

Yeah, I made the physical change to the affect code and did not revert.

The sow command change is still current.