Starting Items Completed on 0.5.0DR3

[krich]

I've completed the Starting Items for 0.5.0DR3. This is a long DIFF and my first time generating a diff, so here goes.

Command line on linux is: diff -uBb original-file updated-file > file.diff

There are three files changed: common/database.h, common/database.cpp, world/client.cpp

The diffs are located here:

client.cpp.diff (http://nctimes.net/~threeofus/krich/client.cpp.diff)

database.h.diff (http://nctimes.net/~threeofus/krich/database.h.diff)

database.cpp.diff (http://nctimes.net/~threeofus/krich/database.cpp.diff)


regards,

krich

[Merth]

Thanks for the work! I'm putting this as a sticky until we can get to it.

[kanechart]

Thanks bro good work :)

[krich]

Warning: This seems to totally screw up when compiled under windows. Works fine under Linux. Trying to figure that out at the moment.

Regards,

krich

[DeletedUser]

Hes here to stop win32 compiling, STOP HIM! :o

Thanks for the assistance :)

[krich]

Hes here to stop win32 compiling, STOP HIM!

Bah, foiled again. It turns out not to be a Windows problem afterall. Looks like the crashing problem was some invalid data in the starting_items table.

Database::GetItem(int32) does not take kindly to being called with zero. Causes a segmentation fault for some reason. I couldn't figure out a good way of error checking before that call (I suspect zero is not the only value that will make this function segfault).

Anyway, don't put invalid itemids in your starting_items table and you'll be fine with this enhancement.

<bad-dubbing>Hehe...Image, my next enhancement will have unstoppable Linux kung-fu. Your victory will be short lived!</bad-dubbing>

Regards,

krich

[Trumpcard]

Ok, I merged this in this morning... Looks like it's working good with my database (using TCS's, but I think his starting items table is based off Drawdes and Lurkers) ... I did notice the 0 add segfault, so I wrapped to add calls if an if(myitem) to get around that..

Also, I modified some of your logging.

I've pushed this out to CVS, so should be ready for your verification.
Let me know if you see any problems with it, or changes that need to be made. I hand to hand merge the changes as the diffs were too far apart from the code base.

Thanks for the donation!

[krich]

Looks good.

Thanks,

krich

[Trumpcard]

Thanks krich.. God, I've never made so many typos at one time as I did in that last message!