Faction items not working

[ChaosSlayerZ]

I would like to report that I have tested faction giving items - and they do not appear to work.

I have made a custom faction item which was supose to increase my faction by +1k faction points - but it had no effect on the npc on said faction

[ChaosSlayerZ]

bump!
any insights from the devs on this one?

[Rogean]

fix it and submit the code!

Otherwise will have to wait until someone has a chance to look at it, which is purely up to any individual that wants to or has the time do.

[ChaosSlayerZ]

well I was just trying to get to some sort of confirmation that this is indeed a recognized bug and not something I simply screwed up to understand =P

As long as devs are aware of this- no rush =)

[trevius]

I don't recall seeing anywhere that items are factored into faction at all. Here is where bonuses are calculated for factions, but it currently only seems to add spell bonuses:

// EverHood - Faction Mods for Alliance type spells
void Mob::AddFactionBonus(uint32 pFactionID,sint32 bonus) {
    map <uint32, sint32> :: const_iterator faction_bonus;
	typedef std::pair <uint32, sint32> NewFactionBonus;

	faction_bonus = faction_bonuses.find(pFactionID);
	if(faction_bonus == faction_bonuses.end()){
		faction_bonuses.insert(NewFactionBonus(pFactionID,bonus));
	}else{
		if(faction_bonus->second<bonus){
			faction_bonuses.erase(pFactionID);
			faction_bonuses.insert(NewFactionBonus(pFactionID,bonus));
		}
	}
}

sint32 Mob::GetFactionBonus(uint32 pFactionID) {
    map <uint32, sint32> :: const_iterator faction_bonus;
	faction_bonus = faction_bonuses.find(pFactionID);
	if(faction_bonus != faction_bonuses.end()){
			return (*faction_bonus).second;
	}
	return 0;
}

[ChaosSlayerZ]

for testing reference, this is one item with faction I am aware of, that worked on LIVE:

http://everquest.allakhazam.com/db/item.html?item=7106

[So_1337]

And another.