Buffer Overflow with rev1625 and up

[cubber]

I was using rev 1616 with no issues the server started fine. This is on gentoo x86 btw. If I upgrade to rev 1630 the latest in svn as of this writing I get the following on server startup.

+ LNAME=zone
+ '[' '' = test ']'
++ pwd
+ P=/opt/eqemu
+ export LD_LIBRARY_PATH=:/opt/eqemu
+ LD_LIBRARY_PATH=:/opt/eqemu
+ mkdir -p logs
+ '[' '!' -e .lock-zones -a '!' -e .lock-world ']'
+ for f in 'logs/eqemu_*.log'
+ '[' 'logs/eqemu_*.log' = logs/eqemu_commands_zone.log ']'
+ rm -f 'logs/eqemu_*.log'
+ '[' '!' -e .lock-world ']'
+ touch .lock-world
+ sleep 15
+ ./persist_world
*** buffer overflow detected ***: ./world terminated
======= Backtrace: =========
/lib/libc.so.6(__fortify_fail+0x50)[0xb7194850]
/lib/libc.so.6(+0xe18aa)[0xb71928aa]
/lib/libc.so.6(__strcpy_chk+0x44)[0xb7191bb4]
./world(_ZN14SharedDatabase11DBLoadItemsEij+0x1bfe)[0x80d730c]
[0x6e657072]
======= Memory map: ========
08048000-081a0000 r-xp 00000000 fd:01 188627     /opt/eqemu/world
081a0000-081a1000 r--p 00157000 fd:01 188627     /opt/eqemu/world
081a1000-081a9000 rw-p 00158000 fd:01 188627     /opt/eqemu/world
081a9000-08615000 rw-p 00000000 00:00 0          [heap]
ab487000-b14e7000 rw-p 00000000 00:00 0 
b14e7000-b5879000 rw-s 00000000 00:04 248446977  /SYSV4901e001 (deleted)
b5879000-b587a000 ---p 00000000 00:00 0 
b587a000-b607a000 rw-p 00000000 00:00 0 
b607a000-b607b000 ---p 00000000 00:00 0 
b607b000-b687b000 rw-p 00000000 00:00 0 
b687b000-b687c000 ---p 00000000 00:00 0 
b687c000-b707c000 rw-p 00000000 00:00 0 
b707c000-b7086000 r-xp 00000000 08:03 116735     /lib/libnss_files-2.11.2.so
b7086000-b7087000 r--p 00009000 08:03 116735     /lib/libnss_files-2.11.2.so
b7087000-b7088000 rw-p 0000a000 08:03 116735     /lib/libnss_files-2.11.2.so
b7088000-b708a000 rw-p 00000000 00:00 0 
b708a000-b7091000 r-xp 00000000 08:03 116736     /lib/librt-2.11.2.so
b7091000-b7092000 r--p 00006000 08:03 116736     /lib/librt-2.11.2.so
b7092000-b7093000 rw-p 00007000 08:03 116736     /lib/librt-2.11.2.so
b7093000-b70af000 r-xp 00000000 fd:02 395936     /usr/lib/gcc/i686-pc-linux-gnu/4.4.3/libgcc_s.so.1
b70af000-b70b0000 r--p 0001b000 fd:02 395936     /usr/lib/gcc/i686-pc-linux-gnu/4.4.3/libgcc_s.so.1
b70b0000-b70b1000 rw-p 0001c000 fd:02 395936     /usr/lib/gcc/i686-pc-linux-gnu/4.4.3/libgcc_s.so.1
b70b1000-b71f1000 r-xp 00000000 08:03 116188     /lib/libc-2.11.2.so
b71f1000-b71f3000 r--p 0013f000 08:03 116188     /lib/libc-2.11.2.so
b71f3000-b71f4000 rw-p 00141000 08:03 116188     /lib/libc-2.11.2.so
b71f4000-b71f7000 rw-p 00000000 00:00 0 
b71f7000-b71f9000 r-xp 00000000 08:03 116820     /lib/libutil-2.11.2.so
b71f9000-b71fa000 r--p 00001000 08:03 116820     /lib/libutil-2.11.2.so
b71fa000-b71fb000 rw-p 00002000 08:03 116820     /lib/libutil-2.11.2.so
b71fb000-b7210000 r-xp 00000000 08:03 116731     /lib/libpthread-2.11.2.so
b7210000-b7211000 r--p 00014000 08:03 116731     /lib/libpthread-2.11.2.so
b7211000-b7212000 rw-p 00015000 08:03 116731     /lib/libpthread-2.11.2.so
b7212000-b7214000 rw-p 00000000 00:00 0 
b7214000-b7316000 r-xp 00000000 fd:02 330676     /usr/lib/libperl.so.1.5.8
b7316000-b7317000 ---p 00102000 fd:02 330676     /usr/lib/libperl.so.1.5.8
b7317000-b7318000 r--p 00102000 fd:02 330676     /usr/lib/libperl.so.1.5.8
b7318000-b731c000 rw-p 00103000 fd:02 330676     /usr/lib/libperl.so.1.5.8
b731c000-b7320000 rw-p 00000000 00:00 0 
b7320000-b7456000 r-xp 00000000 fd:02 332166     /usr/lib/libcrypto.so.0.9.8
b7456000-b745e000 r--p 00135000 fd:02 332166     /usr/lib/libcrypto.so.0.9.8
b745e000-b746d000 rw-p 0013d000 fd:02 332166     /usr/lib/libcrypto.so.0.9.8
b746d000-b7470000 rw-p 00000000 00:00 0 
b7470000-b74b5000 r-xp 00000000 fd:02 327693     /usr/lib/libssl.so.0.9.8
b74b5000-b74b6000 r--p 00045000 fd:02 327693     /usr/lib/libssl.so.0.9.8
b74b6000-b74b9000 rw-p 00046000 fd:02 327693     /usr/lib/libssl.so.0.9.8
b74b9000-b74cc000 r-xp 00000000 08:03 116739     /lib/libnsl-2.11.2.so
b74cc000-b74cd000 r--p 00012000 08:03 116739     /lib/libnsl-2.11.2.so
b74cd000-b74ce000 rw-p 00013000 08:03 116739     /lib/libnsl-2.11.2.so
b74ce000-b74d0000 rw-p 00000000 00:00 0 
b74d0000-b74d9000 r-xp 00000000 08:03 116310     /lib/libcrypt-2.11.2.so
b74d9000-b74da000 r--p 00008000 08:03 116310     /lib/libcrypt-2.11.2.so
b74da000-b74db000 rw-p 00009000 08:03 116310     /lib/libcrypt-2.11.2.so
b74db000-b7502000 rw-p 00000000 00:00 0 
b7502000-b761f000 r-xp 00000000 fd:02 337895     /usr/lib/mysql/libmysqlclient.so.15.0.0
b761f000-b7621000 r--p 0011c000 fd:02 337895     /usr/lib/mysql/libmysqlclient.so.15.0.0
b7621000-b7662000 rw-p 0011e000 fd:02 337895     /usr/lib/mysql/libmysqlclient.so.15.0.0
b7662000-b7664000 rw-p 00000000 00:00 0 
b7664000-b7666000 r-xp 00000000 08:03 116729     /lib/libdl-2.11.2.so
b7666000-b7667000 r--p 00001000 08:03 116729     /lib/libdl-2.11.2.so
b7667000-b7668000 rw-p 00002000 08:03 116729     /lib/libdl-2.11.2.so
b7668000-b7679000 r-xp 00000000 08:03 116286     /lib/libz.so.1.2.3
b7679000-b767a000 ---p 00011000 08:03 116286     /lib/libz.so.1.2.3
b767a000-b767b000 r--p 00011000 08:03 116286     /lib/libz.so.1.2.3
b767b000-b767c000 rw-p 00012000 08:03 116286     /lib/libz.so.1.2.3
b767c000-b76a0000 r-xp 00000000 08:03 116728     /lib/libm-2.11.2.so
b76a0000-b76a1000 r--p 00023000 08:03 116728     /lib/libm-2.11.2.so
b76a1000-b76a2000 rw-p 00024000 08:03 116728     /lib/libm-2.11.2.so
b76a2000-b7786000 r-xp 00000000 fd:02 395920     /usr/lib/gcc/i686-pc-linux-gnu/4.4.3/libstdc++.so.6.0.13
b7786000-b778a000 r--p 000e4000 fd:02 395920     /usr/lib/gcc/i686-pc-linux-gnu/4.4.3/libstdc++.so.6.0.13
b778a000-b778b000 rw-p 000e8000 fd:02 395920     /usr/lib/gcc/i686-pc-linux-gnu/4.4.3/libstdc++.so.6.0.13
b778b000-b7792000 rw-p 00000000 00:00 0 
b779a000-b77a4000 r-xp 00000000 fd:01 188628     /opt/eqemu/libEMuShareMem.so
b77a4000-b77a5000 r--p 00009000 fd:01 188628     /opt/eqemu/libEMuShareMem.so
b77a5000-b77a6000 rw-p 0000a000 fd:01 188628     /opt/eqemu/libEMuShareMem.so
b77a6000-b77aa000 rw-p 00000000 00:00 0 
b77aa000-b77ab000 r-xp 00000000 00:00 0          [vdso]
b77ab000-b77c7000 r-xp 00000000 08:03 116726     /lib/ld-2.11.2.so
b77c7000-b77c8000 r--p 0001b000 08:03 116726     /lib/ld-2.11.2.so
b77c8000-b77c9000 rw-p 0001c000 08:03 116726     /lib/ld-2.11.2.so
bf89e000-bf8a3000 rw-p 00000000 00:00 0          [stack]
./persist_world: line 14:  2574 Aborted                 (core dumped) ./world "$@"
+ '[' '!' -e .lock-launcher ']'
+ touch .lock-launcher
+ ./eqlaunch zone

I downgraded to rev 1625 and had the same issue, actually the trace above is from rev 1625.

Reverting back to my 1616 build works fine again.

Any ideas how I can fix this and update?