What's wrong with this quest?

[Randymarsh9]

I just modified one of my old quests to work as a teleporter. The npc doesn't respond to hails or when you give him money. I did enable quest globals for him.

sub EVENT_SAY{
 if ($text=~/hail/i){
 quest::say("Greetings, $name. I have the ability to teleport you to a variety of [zones], but it will cost you 50 platinum for each teleport.");
 }
 if ($text=~/zones/i){
 quest::say("I can send you to [Cazic] Thule, [Cobalt] Scar, [Dawnshroud], [Iceclad], [Twilight] Sea, and [Wakening] Lands. You must have sufficient [credit].");
 }
 if ($text=~/credit/i){
 quest::say("For each platinum you give me, you will earn one credit for teleports. You can also see your current [balance].");
 }
 if ($text=~/balance/i){
 if ($porter >= 1) {
 quest::say("Your current credit is $porter");
 $porter = undef;
}
 else {
 quest::say("You have 0 credit.");
 $porter = undef;
}
}
 if ($text=~/cazic/i){
 if ($porter >= 50) {
 quest::setglobal("porter", $porter-50, 0, "Y9");
 quest::say("Farewell");
 quest::selfcast(1375)
 $porter = undef;
}
else {
quest::say("You need more credits!");
$porter = undef;
	}
}


if ($text=~/cobalt/i){
 if ($porter >= 50) {
 quest::setglobal("porter", $porter-50, 0, "Y9");
 quest::say("Farewell");
 quest::selfcast(2025)
 $porter = undef;
}
else {
quest::say("You need more credits!");
$porter = undef;
	}
}


if ($text=~/dawnshroud/i){
 if ($porter >= 50) {
 quest::setglobal("porter", $porter-50, 0, "Y9");
 quest::say("Farewell");
 quest::selfcast(2431)
 $porter = undef;
}
else {
quest::say("You need more credits!");
$porter = undef;
	}
}


if ($text=~/iceclad/i){
 if ($porter >= 50) {
 quest::setglobal("porter", $porter-50, 0, "Y9");
 quest::say("Farewell");
 quest::selfcast(2022)
 $porter = undef;
}
else {
quest::say("You need more credits!");
$porter = undef;
	}
}


if ($text=~/twilight/i){
 if ($porter >= 50) {
 quest::setglobal("porter", $porter-50, 0, "Y9");
 quest::say("Farewell");
 quest::selfcast(2426)
 $porter = undef;
}
else {
quest::say("You need more credits!");
$porter = undef;
	}
}


if ($text=~/wakening/i){
 if ($porter >= 50) {
 quest::setglobal("porter", $porter-50, 0, "Y9");
 quest::say("Farewell");
 quest::selfcast(2024)
 $porter = undef;
}
else {
quest::say("You need more credits!");
$porter = undef;
	}
}
}

sub EVENT_ITEM {
if($platinum >= 1){
  	quest::setglobal("porter", $porter+$platinum, 0, "Y9");
	quest::say("Your credit has risen.");
	$porter = undef;
	}
else {
	quest::say("I only take platinum.");
	$porter = undef;
    plugin::return_items(\%itemcount);
    }
}

[Andrew80k]

Did you reload the quests?

[Derision]

You are missing a ; after each occurrence of quest::selfcast

[Randymarsh9]

thank you, that's what I get for copy/pasting.

[Justsomeguy]

hashes are now used instead of the old $porter restricted vars. Consider using $qglobals{porter} as the old method is deprecated. Using the new way does not require you to use all of the $porter = undef; as there are many potential errors when using that.

example:

 if ($qglobals{porter} >= 50) {

[Randymarsh9]

Ok, I have a new problem. I am trying to make a quest that checks the persons class. I have tried all formats I can think of and it will not check the class properly. Right now it is just an extremely simple quest because I am trying to figure out what's wrong with it. Knowing me, I probably just have something out of order.

sub EVENT_SAY{
 if ($text=~/hail/i){
  if ($class == "shadowknight"){
  quest::say("Hello.");
  }
 }
}

For the class I have also tried
if ($class = "shadowknight"){
if ($class = 'shadowknight'){
if ($class == 'shadowknight'){
if ($class eq "shadowknight"){
if ($class eq 'shadowknight'){

[Thovar]

Originally Posted by Derision

You are missing a ; after each occurrence of quest::selfcast

Funny how this solved my problem and didn't realize this WAS the problem I was having. when I saw this posted I looked through my quest I was having an issue with and i as well was missing that silly little ; at the end of one of my many lines in this quest, and all along I thought I had a more complicated problem. ROFL... silly Monday details.