things about 3.13 that i noticed

[neotokyo]

ok some things i might have got wrong, but please take a look into it nonetheless:

attack.cpp: the fix for h2h isnt in anymore (skill = 29 instead of 2
attack.cpp: avatar now would proc 2x since you forgot to remove old code
client.cpp: line 2549 - you missed one part of the xp-fix?
client.cpp: changed CheckUsedName param#1 to const char, but not all calls to that functions are updated
client_process.cpp: line2381 - wrong cast to NPC (--> should be client)
loottables.cpp: did you miss trump's loot fix, or didn't i get it?

take care,
neo

[neotokyo]

so. few minutes later:

i merged my Delta#3 changes into 3.13 (actually i merged 3.13 into Delta3 --- that was a lot easier )

and i cant compile.
Image: did you ever try to compile without SHAREMEM defined? there seems to be some problem with the doors, and not using the mem-dll. take a look into it if you got a min pls.

[Trumpcard]

Hey Neo, take a look at my post in the linux forum..

The problem is that the functions def's are wrapped in #ifdef SHAREMEM 's , but the actual calls to the functions aren't.

I made a few changes in the source and have it compiling properly now and everything appears to be working correctly.

[Syntaks]

Also,

Sourcing the new db file gives me this :
Column count doesn't match value count at row 1

Something else, I remember Image saying that zone points would be fixed, I still see some 0,0,3 points in the admin program. And zoning into Halas, I get a message saying there aren't any zone points in the zone...

[neotokyo]

Trump: you disappoint me. instead of adding the 2 missing functions for the "normal" version you just remove their calls ??

anyway ... i added the 2 functions and if i can log in i'll test if it works. at least i could compile without changing any other file than database.cpp and database.h

[Trumpcard]

I took the easy route.. I had 20 minutes this morning before work... I think to get those functions working though you'll need to get the sharemem functionality working correctly, but Im probably wrong there.

I didnt see the purpose of adding it if it's not going to be used. You're the professional coder, not me! LOL Im a systems engineer, architecture is my speciality, not good code practices

[neotokyo]

hm sharemem was just an addon as i see it.
the point was to load all the doors (and some other items) on startup of the zone server. so you could do the zoning faster with all items already in memory.

sharemem just reduces the memory usage on that feature. you can now have the one without the other too.

[kpr]

I'm new to all of this but for the avatar fix can't you use the 'goodEffect'? to see if the spell proc on the weapon is benifical? 99% of the benefical procs are cast on the client (minus dispell procs). I modified the proc code to the following:

if(spells[weapon->common.spellId].goodEffect == 1 || spells[weapon->common.spellId].goodEffect == 2)
SpellFinished(weapon->common.spellId, GetID(), 10, 0);
else
SpellFinished(weapon->common.spellId, other->GetID(), 10, 0);


like i said this is my first time messing with this, awesome code but is this correct? You guys seemed to know what you were doing so I'm assuming you've already ran across this but just checking thanks.