PBAE and distance checks

RangerDown · #1 07-08-2004, 03:03 PM

I was trying to put in Vox's breath (Frosty Death, spell#952 -- or Frosty Death2, spell#1356), and the breath never would go off. After turning spell debugging on I saw what was happening: the entry in spells_us.txt had a range of 0. I assume most if not all of the PBAE spells have a range of 0 since range isn't applicable with a pbae. I was able to get the breath to go off only if I /summoned her on top of me.

I made this change to the MobAI.cpp file so that if the spell is targettype 4 (pbae) then the distance check doesn't have to pass:

The change is in line 84 of zone/MobAI.cpp. (As of the 6/21/04 release it's on line 84 -- dunno if that's the case in later CVS's)

Change from:

Code:

dist &lt;= spells[AIspells[i].spellid].range

to:

Code:

(dist &lt;= spells[AIspells[i].spellid].range || spells[AIspells[i].spellid].targettype == 4)

If you wanna change the debug messages so they now accurately show the new logic:

Line 92, add this to the end of the line:

Code:

&lt;&lt; "||targettype[" &lt;&lt; spells[AIspells[i].spellid].targettype &lt;&lt; "]==4"

and change line 206 to read:

Code:

cout &lt;&lt; "Mob::AICastSpell: NotCasting: spellid=" &lt;&lt; AIspells[i].spellid &lt;&lt; ", tar=" &lt;&lt; tar->GetName() &lt;&lt; ",tar=" &lt;&lt; tar->GetName() &lt;&lt; ", dist[" &lt;&lt; dist &lt;&lt; "]&lt;=" &lt;&lt; spells[AIspells[i].spellid].range &lt;&lt; "||targettype[" &lt;&lt; spells[AIspells[i].spellid].targettype &lt;&lt; "]==4" &lt;&lt; ", mana_cost[" &lt;&lt; mana_cost &lt;&lt; "]&lt;=" &lt;&lt; GetMana() &lt;&lt; ", cancast[" &lt;&lt; AIspells[i].time_cancast &lt;&lt; "]&lt;=" &lt;&lt; Timer::GetCurrentTime() &lt;&lt; endl;

(Damn that's a long line :P)

After that, Vox started AE'ing quite nicely... much to the dismay of cocky young adventurers everywhere :lol:

sotonin · #2 07-09-2004, 03:11 AM

Very cool indeed. You can come check it out on PEQTGC classic server if you like )

killspree · #3 07-18-2004, 11:47 PM

This doesn't really fix the underlying problem, but it's a good workaround. I think the code should be modified to use the AE Range field in spells_us.txt for pbae, as that's the value that determines the radius of the AE effect.

sotonin · #4 07-19-2004, 01:46 AM

Agreed. This should be fixed. But for the time being. All our uber mobs on PEQTGC are aeing. which makes for some interesting fights )

killspree · #5 07-19-2004, 12:48 PM

Well that's definitely a good thing to hear. I know lots of folks had problems a long while ago with mobs not AEing properly. Nice to see it's been fixed.