[Bugs] Corpses issues with leavecorpses set to 1

[Magoth78]

Hi there,

On my server I've set the leavecorpses variable to 1 so people can loot each other after being killed.
But when a player dies (from PvP or PvE) the corpse disapears. Everyone has to zone to see the corpse. Looks like an info sent to clients is missing when a Player dies.

Does anyone experience the same problem?

Thx,
Mag

[sdabbs65]

Originally Posted by Magoth78

Hi there,

On my server I've set the leavecorpses variable to 1 so people can loot each other after being killed.
But when a player dies (from PvP or PvE) the corpse disapears. Everyone has to zone to see the corpse. Looks like an info sent to clients is missing when a Player dies.

Does anyone experience the same problem?

Thx,
Mag

What server version are you running ?
this is not a problem on my shard 6.0DR1

[Magoth78]

I'm running a 0.6.0dr2 server.

On Empire1, I used to have a 0dr1 server, all was fine. I guess I gotta find the dr1 sources and see the differences in attack.cpp and playercorpse.cpp :/

Anyway thx for the answer,
Mag

[FaerinTelDanor]

I have the same problem with 0.6.0 dr3 ... haven't been able to track down the problem yet.

[Magoth78]

sdabbs65> By any chance, could you send me your attack.cpp (in your 0.6.0dr1 sources), please? (funzy78@hotmail.com)

Cause, I remember having this bug in 6.0dr1 just after LE added the PvPreward/PvPitem/LootCoin features. But he fixed it very quickly and I dunno if the changes have ever been sent to cvs.

So maybe you got the changes pre-PvPreward and in this case, this won't help me, or post-PvPreward and it might help me.

Thx by advance,
Mag

[Magoth78]

I've looked into my old 5.7dr6 sources and checked the file. The corpse is made in the same way that in the 0.6.0dr2 sources (minus the check for the PvPreward variable).

// now we apply the exp loss, unmem their spells, and make a corpse
	// unless they're a GM
	if(!GetGM())
	{
		if(exploss)
			SetEXP(GetEXP() - exploss > 1 ? GetEXP() - exploss : 1, GetAAXP());

		BuffFadeAll();
		UnmemSpellAll(false);

		// check db variable 'leavecorpses'
		char tmp[20] = {0};
		database.GetVariable("leavecorpses", tmp, 20);
		int leavecorpses = atoi(tmp);
		if(leavecorpses)
		{
			// creating the corpse takes the cash/items off the player too
			Corpse *new_corpse = new Corpse(this, exploss);
			entity_list.AddCorpse(new_corpse, GetID());
		}

//		if(!IsLD())//Todo: make it so an LDed client leaves corpse if its enabled
//			MakeCorpse(exploss);
	}

So the solution is *probably* not there. Now I guess I gotta check how the Corpse() function is working since the PvPreward/LootCoin variables and the SetPKItem() function have been added.

I really do need to find a fix because I got some bad issues with the corpses on 6.0dr2...
1/ corpses poof just after being killed by a npc/pc, you have to zone/camp to see the corpse
2/ or corpses poof just after being killed by pain and suffering and you are not able to see them even after zoning or camping, you have to reboot the zone...

Mag
ps: sdabbs, can you check in your attack.cpp (.6.0dr1 right?), look for the leavecorpse check called in the void Client:eath function and says if you have any check for the PvPreward/LootCoin/PvPitem variables, please? if it's the case, that would really help if you could send me the files attack.cpp and playerscorpses.cpp. Thanks.