Aggravated - HELP (please :) )

sonicintuition · #1 09-01-2007, 05:18 AM

Hello,

I have a bit of a problem that I'm trying to find the solution for -

I'm trying to create a buff bot that tells non-casting classes (warriors, monks, rogues, berserkers) that they cannot cast spells therefore do not need the buff bot's services. Here is a sample of the code I was trying this with:

sub EVENT_SAY
{
if($text=~/hail/i && $class == 'Warrior')
{
quest::say("You are a warrior. You cannot cast spells.");
}
}

According to other code examples, and logic, this should work. If a warrior hails this NPC, the npc will reply as above - however, even a Shaman, or Necro, or whatever (I tried a few) classes will also see that message. So it seems that the NPC isn't seeing what class the user really is. Is my syntax off, or is this broken? I'm pulling my hair out...

Regards,
Sonic

tcsmyworld · #2 09-01-2007, 06:06 AM

Been awhile since I even looked at this stuff

Not sure, but seems that should work, but like I said been a long time since I even looked at this.
And the perl quests weren't my favorite anyways

Hope it works/helps. (I have no way to test it)

sub EVENT_SAY{
if($text=~/hail/i) && ($class == 'Warrior' || $class == 'Monk' || $class == 'Rogue' || $class == 'Berserker')
{
quest::say("You are a $class . You cannot cast spells.");
}
}

Angelox · #3 09-01-2007, 06:36 AM

This should work (if it does, notice the double brackets added) ;

Code:

sub EVENT_SAY{
if(($text=~/hail/i && $class == 'Warrior')){
quest::say("You are a warrior. You cannot cast spells.");
 }
}

This does work

Code:

sub EVENT_SAY{
  if (($text=~/hail/i&&$race eq 'Human'&&$class eq 'Enchanter')){
  quest::say("I know you!!");
 }
}

The $race is just there to show you how to add more. you can find many examples of stuff like this in my quest pack posted with the database at Rathe Forums. If you do get it, look in Tutorialb, PoK, Gunthak - I remember I did a lot of this stuff in those zones.

Quote:

Originally Posted by sonicintuition

Hello,

I have a bit of a problem that I'm trying to find the solution for -

I'm trying to create a buff bot that tells non-casting classes (warriors, monks, rogues, berserkers) that they cannot cast spells therefore do not need the buff bot's services. Here is a sample of the code I was trying this with:

sub EVENT_SAY
{
if($text=~/hail/i && $class == 'Warrior')
{
quest::say("You are a warrior. You cannot cast spells.");
}
}

According to other code examples, and logic, this should work. If a warrior hails this NPC, the npc will reply as above - however, even a Shaman, or Necro, or whatever (I tried a few) classes will also see that message. So it seems that the NPC isn't seeing what class the user really is. Is my syntax off, or is this broken? I'm pulling my hair out...

Regards,
Sonic

sfisque · #4 09-01-2007, 01:25 PM

the error is in the operator.

"==" is for numeric comparison, "eq" is for string comparison.

your if should read:

Code:

if($text=~/hail/i && $class eq 'Warrior' )
{
  # do some work in here
}

== sfisque

sonicintuition · #5 09-01-2007, 04:02 PM

Duh, why didn't I think of that? Using a numerical based operator instead of a string based operator ... Thanks for helping out with this all

Regards,
Sonic

sonicintuition · #6 09-02-2007, 12:24 AM

Hmm ..seems that using string operators makes no difference either.

Example:

Quote:

sub EVENT_SAY
{
if($text=~/hail/i && $class eq 'Rogue' || $class eq 'Warrior')
{
quest::say("You are a $class. You cannot cast spells.");
}
if($text=~/hail/i && $class ne 'Rogue' || $class ne 'Warrior')
{
quest::say("Would you like me to scribe your spells?");
}
}

According to you guys, this should work ..but it still doesn't work. I hailed this npc with a wizard and the npc said both lines. I hailed her with a rogue, and she said both lines ...I'm stumped? I'm going to try adding the other parenthises to see if that helps.. will post back here if it does.

Regards,
Sonic

sonicintuition · #7 09-02-2007, 12:33 AM

I added parenthisis ...does nothing. :(

sfisque · #8 09-02-2007, 12:59 AM

Quote:

Originally Posted by sonicintuition

Hmm ..seems that using string operators makes no difference either.

Example:

According to you guys, this should work ..but it still doesn't work. I hailed this npc with a wizard and the npc said both lines. I hailed her with a rogue, and she said both lines ...I'm stumped? I'm going to try adding the other parenthises to see if that helps.. will post back here if it does.

Regards,
Sonic

logic failure. && has higher precedence than ||. you basically want, in this case:

Code:

if($text=~/hail/i && ( $class eq 'Rogue' || $class eq 'Warrior') )

you need to group the two class comparisons because if you dont, the logic says:

if the text contains "hail" and class eq 'Rogue'

OR

class eq 'Warrior'

whereas you want:

if the text contains 'hail'

AND

the class is either Rogue or Warrior

== sfisque