Summoned Pets Turn to Ghosts

Breea · #1 09-08-2007, 05:39 PM

I know its been chatted up, but it needs to be addressed. There is an issue when the owner of a pet zones out, it leaves a shadow copy of itself in the old zone, even with persistent zones turned off if there is people in that zone afking or boxing the pets can be item duped by placing tons of items on the pets, zoning back and forward till someone has enough plat and items and then kill each pet for those items. The shadow version of the pet is placed in the npc_types table as SumEarthR001 or SumFireR001 etc, so as I'm trying to track this down it seems that there is a problem or something overlooked when someone leaves the zone there doesn't seem to be a kill or depop command for the pet. I've tried writing and applying quest scripts to run sub EVENT_SPAWN { quest::depop(); } but that does not work naturally being the mob isn't a spawn from the DB itself.

Can we, the community please get to work on this code. I'd be willing to start in but I'm only 70ish % through trying to learn the code myself. Any coding I can apply or conjure I will but this bug is definitely taking the mages out of the game or at least ruining a lot of server's economies =(.

Breea · #2 09-08-2007, 06:02 PM

Here we go...

Code:

	if(tmp->GetOwnerID() != GetID()) {
		SetPetID(0);
		// WE NEED TO KILL THE PET HERE!!!!!
		return(NULL);
	}

I'm assuming adding a kill code here in pets.cpp will get the job done?

Would this work for instance?

Code:

	if(tmp->GetOwnerID() != GetID()) {
		SetPetID(0);
        // Attempting to remove shadow pet.
		depop();
		return(NULL);
	}

Not sure that depop() is registered in any global functions or not =S

Breea · #3 09-08-2007, 06:13 PM

Also if we can get the pets working adding the same to the mounts would be an easy fix.

Breea · #4 09-08-2007, 07:39 PM

I tried strait up Depop(); that crashed the zone server... should it be pet->Depop(); ??

**KLS** · #5 09-08-2007, 07:58 PM

How exactly can I reproduce this 100% of the time? Or does this only happen sometimes?

Breea · #6 09-08-2007, 08:50 PM

Quote:

Originally Posted by KLS

How exactly can I reproduce this 100% of the time? Or does this only happen sometimes?

It happens 100% of the time on a source build (last 5 releases) on a linux (fedora 6) quad-core box.

It is also adding these as npcs in the npc_types table.. Basically this could become a stability comprimise if a mage or pet class decides to just zone back and forth a few thousand times.

**KLS** · #7 09-09-2007, 06:14 AM

Hm well it doesn't happen here as described.

Player1 in zone with pet, player2 in same zone. Player1 zones out and pet disappears.

I'm not sure how or why it's getting added to your npc_types table. The only code that does that from stock emu code is command related...

Not sure what's going on but that doesn't sound good.