Spell names too long

[Bulle]

There are a few spells in spells_us.txt (Titanium) which have a name of more than 31 characters. Sadly the SPDat_Spell_Struct only allocates 32 bytes for the spell name. My guess is that the player_1 field gets overwritten on spells loading (which may have no noticeable effect, I have no idea what this field is for).

I spotted this potential problem while working on the spells file to make a full table out of it. Would a developer have a look at this, and possibly enlarge the name field if it has no other nasty side effect ? I cannot answer for the last question as I lack the experience needed in the Emu server code.

Here are the beginning of the SPDat and the spell entries with names over 31 characters :

struct SPDat_Spell_Struct
{
/* 000 */	int			id;	// not used
/* 001 */	char		name[32]; // Name of the spell
/* 002 */	char		player_1[32]; // "PLAYER_1"

mysql> select spellid,name from spells where length(name) > 31;
+---------+--------------------------------------+
| spellid | name                                 |
+---------+--------------------------------------+
|    4264 | Xalirilan's Lesser Discombobulation  |
|    4266 | Xalirilan's Greater Discombobulation |
|    4267 | Wuggan's Lesser Discombobulation     |
|    4269 | Wuggan's Greater Discombobulation    |
|    4336 | Minor Reanimation Efficiency III     |
|    5256 | Unswerving Hammer of Retribution     |
|    5468 | Summon Calliav's Jeweled Bracelet    |
|    5475 | Summon Calliav's Platinum Choker     |
|    6189 | Cursed Touch of the Lightningcaller  |
+---------+--------------------------------------+
9 rows in set (0.02 sec)

[apezdr2]

EZ Server is having problems with this ATM As well.
I myself am having problems with the Unswerving hammer of retribution

[joligario]

KLS committed a fix for this in 1590