5.7DR4 6-11 code ... server to client HP update still broke?

[Derision]

I brought up my server with the 6-11 code and noticed that #heal and healing spells and HP regen didn't seem to be working. The client seems to indicate HP are regenerating but when I zone, they drop back down again. I am pretty sure this is an opcode issue, but I am just looking for confirmation.

I did a quick test on Scorpius2K's server and regen seemed OK, which made me wonder whether the problem was on my end, or maybe Scorp has that issue fixed.

[Scorpious2k]

Originally Posted by Derision

I did a quick test on Scorpius2K's server and regen seemed OK, which made me wonder whether the problem was on my end, or maybe Scorp has that issue fixed.

As far as I know, with the exception of the new ones Dspirit posted, all the opcodes on our server are identical to the 6-11 release. I'm assuming you rebuilt all programs, so they should be the same.

[Derision]

As far as I know, with the exception of the new ones Dspirit posted, all the opcodes on our server are identical to the 6-11 release. I'm assuming you rebuilt all programs, so they should be the same.

Thanks for the reply. Yes, I built the 6-11 code from scratch. As your server is legit, I can't test the #heal command there, can you confirm that if you target yourself and do #heal that your HP go back to 100% and remain at 100% if you #zone ?

[Scorpious2k]

I tried #heal and nothing happened. The hp bar didn't change and after zoning showed the same value as before zoning.

[Derision]

After a bit of packet sniffing of HPUpdate OP codes that yours and Bush's server were sending me, I discovered I needed to add:

ds->spawn_id = GetID();

into Mob::SendHPUpdate and all my healing started to work properly again (even #heal).

One thing I did note is that your server seemed to be sending HPUpdates with an opcode of 0x0244, not 0x0243 as it is in the 06-11 code on cvs.biosprite.net. During my testing I tried both opcodes and they both seemed to do the same thing.

[Scorpious2k]

Originally Posted by Derision

One thing I did note is that your server seemed to be sending HPUpdates with an opcode of 0x0244, not 0x0243 as it is in the 06-11 code on cvs.biosprite.net. During my testing I tried both opcodes and they both seemed to do the same thing.

That was one that Doodman discovered last night. There is also a mob.cpp fix. We also have a few more opcodes thanks to Dspirirt.

I'll be posting these later today when I have time to sit down in front of the computer for a few minutes.

[sianyde]

Which file must I update to implement this fix?