Pc Hatelist and pets

janusd · #1 10-19-2008, 04:09 PM

After the changes to the PC hatelist, pets seem to be somewhat bugged from how they're supposed to work. Originally, with my pet, I could target a mob and tell my pet to attack it and regardless of where my pet was, it would recieve the order and move to attack. Now, my pet has to be within a certain range of the mob, regardless of my own range to the mob. Aside from creating small issues in using pets, this is potentially exploitable.

I think this issue largely arises from the recent client hatelist changes in that a pet originally would get its hatelist from the client's hatelist.

Also, when using a pet, were mobs hitting me, the pet, once done with one mob, would default to the next mob on my hatelist that had been hitting me. Now I have to actively tell the pet to attack before it will.

**AndMetal** · #2 10-20-2008, 12:43 AM

I think it was part of this change in Revision 108 in SVN:

Quote:

==10/17/2008
KLS: Tweaks to /pet attack

zone/attack.cpp diff:

Code:

@@ -4999,7 +4999,7 @@
 		if (mypet->IsFeared()) break; //AndMetal: prevent pet from attacking stuff while feared
 
 		if((mypet->GetPetType() == petAnimation && GetAA(aaAnimationEmpathy) >= 2) || mypet->GetPetType() != petAnimation) {
-			if (mypet->GetHateTop()==0 && target != this && DistNoRootNoZ(*target) <= (RuleR(Pets, AttackCommandRange)*RuleR(Pets, AttackCommandRange))) {
+			if (target != this && mypet->DistNoRootNoZ(*target) <= (RuleR(Pets, AttackCommandRange)*RuleR(Pets, AttackCommandRange))) {
 				mypet->SetHeld(false); //break the hold and guard if we explicitly tell the pet to attack.
 				mypet->SetPetOrder(SPO_Follow);
 				zone->AddAggroMob();

I'm not sure what the intention was behind the change (KLS usually makes those changes for a good reason), although I think we might need more of a Line of Sight check rather than a distance check.

**KLS** · #3 10-20-2008, 02:29 PM

Good point there should also be a distance check to the pet. There's no los check on live so I'm not adding one here. The default pet attack range also feels like it needs increasing.

janusd · #4 10-20-2008, 03:28 PM

Yes it does, KLS. On Live, the raige was pretty fairly large (not insane like 400, but closer to 150 I'd say. Maybe 200)

**joligario** · #5 10-20-2008, 05:33 PM

Pet distance was already defaulted to 150 on TGC from what I remember. I think 200-250 might be better.

janusd · #6 10-20-2008, 10:25 PM

If it's set at 150, then it should be about 250. Never tested the actual range on PEQ.