Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Development

Development::Development Forum for development topics and for those interested in EQEMu development. (Not a support forum)

 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
  #4  
Old 10-15-2006, 10:32 AM
fathernitwit
Developer
 
Join Date: Jul 2004
Posts: 773
Default

hey,nice work. here are my quickly scribed comments as I was merging it in:


Please ignore whitespace when making your diffs.

When adjusting hard coded constants in the code, like exp loss level or pet range, please replace the constants with the rule system instead (placing your value as the default), so people can tune it as they see fit.

as for your pet thing, the DistNoZ returns an absolute distance, not a squared, so you increased the range to 10000. I changed this to 150.

what is this about? did you mean to send out app3 instead of app2 2 lines down?
Code:
+                       EQApplicationPacket app3;
+                       CreateSpawnPacket(&app3, new_corpse);
as for:
Code:
+               AddCash(0,0,0,0);
+               //Add no money because otherwise the corpse tries to use
+               //Uninited Vars and you'll get random amounts of money from the naked corpse
its better to fix the problem (init them to 0 in constructor) than to do this.
Reply With Quote
 


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 01:16 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3