Class Specific quest

[Cisyouc]

Aren't you supposed to use the eq operator and not the == operator for strings?

if($class eq 'Warrior') { /* ... */ }

[Muuss]

Using eq instead of == is a good idea, yes

About the else at the end of your code. It has no sense.

just add plugin::return_items(\%itemcount); without test.

check_handin verifies that you gave the right amount of items and removes them of the list of given items.

At the end of the quest, you call return_items to give back to the player each item that remains in the list. Don't include it in a test, just do it or don't do it.

[paaco]

The quest works now, thank all of you guys for your hard work and patience helping me get it going. Posting the working code, maybe it will help someone else looking to make a class specific quest.

sub EVENT_SAY {
    if ($text=~/hail/i) {
      quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around.");}
    }
    
sub EVENT_ITEM {
  if ($class eq "Warrior") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Paladin") {
    if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Shadow Knight") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Berserker") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(62189);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Monk") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Beastlord") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(6611);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Druid") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Necromancer") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }    
  if ($class eq "Wizard") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Magician") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Enchanter") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Shaman") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29422);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
  if ($class eq "Cleric") {
     if (plugin::check_handin(\%itemcount, 6164 => 1)) {
      quest::summonitem(29442);
      quest::exp(750);
      quest::emote("smiles warmly as he hands you your weapon.");
      quest::ding(); 
    }
    }
      plugin::return_items(\%itemcount); 
      quest::say("These are not the pieces I need.");
  }
}

[paaco]

ok actually it doesn't work lol. This quest is starting to get old :( When you hand in the item now this stuff happens:
quest::exp(750);
quest::emote("smiles warmly as he hands you your weapon.");
quest::ding();

But instead of summoning the correct item for you, he hands you back the mold and says:
These are not the pieces I need.

So basically you can stand there and hand the mold in over and over until you reach max lvl if you want to do 10k turnins =/

[jimbabwe]

i got it working, let me finish it and i'll post it

[jimbabwe]

I added a few comments into the file for you, so you can tweak usability.

#this quest will work for any class as is, however it just gives xp to rogues, rangers, and bards
#this can be fixed by moving the emote, exp and ding functions into the if statements individually.
sub EVENT_SAY 
{
    	if ($text=~/hail/i) 
	{
      	quest::say("Hello $name , I am one of the finest weaponsmiths this land has ever seen. If you find me a mold I will craft you a weapon. However if it is armor you seek, my brother makes the best around."); 
	}
}
    
sub EVENT_ITEM 
{
	if (plugin::check_handin(\%itemcount, 6164 => 1))
	{
		if(($class eq "Warrior") || ($class eq "Paladin") || ($class eq "Shadowknight") || ($class eq "Berserker"))
		{
			quest::summonitem('62189');
		} 
		if(($class eq "Monk") || ($class eq "Beastlord"))
		{
			quest::summonitem('6611');
		} 
		if(($class eq "Druid") || ($class eq "Necromancer") || ($class eq "Magician") || ($class eq "Wizard") || ($class eq "Enchanter") || ($class eq "Cleric"))
		{
			quest::summonitem('29442');
		}
	 	quest::emote("smiles warmly as he hands you your weapon.");
		quest::exp(750);
		quest::ding(); 
    	}
	elsif(plugin::return_items(\%itemcount))
	{
		#this command isn't working.  maybe quest::return_items returns a false value when it gives soemthing back.
		quest::say("These are not the pieces I need.");
	}
}

EDIT: oh, I only tested this on bards, warriors, and wizards... could be bugs.

[paaco]

Nice, thank you Jimbabwe, I'll try this out