tradeskill.cpp and stat modifiers

[John Adams]

Indeed. I've found a handful of skills that cap out well below 252 that literally vomit all over the log files when they still attempt to be raised - sense heading, for one - maxes at 200, but using #setskillall 252, it starts barking that some of my skills are too high. If I understood the code better, I could come up with a way that if a skill increase encounters a skill > than it's possible max, it'll correct and save out the skill data and stop trying.

However, I am scared of Emu source. If I go in there and learn something, my life is over.

[eq4me]

Yes, I saw this too.

A sanity check build into #setskill and #setskillall would do the trick.

Something like:

if (new_skill_value > GetMaxPossibleRank(skillid) {
                     Message(13, "ERROR: Value %d to high for %d ! Setting it to %d", new_skill_value , GetSkillName(tradeskill) ,  GetMaxPossibleRank(skillid);
                     new_skill_value = GetMaxPossibleRank(skillid);
                    }

The variables are only for example, I didnt look in the code.