tradeskill.cpp enhancements

[eq4me]

Originally Posted by InsaneWallaby

The tradeskilling right now is ridiculous--whoever heard of failing 30-50% of your metal bits with a 144 smithing skill?

Yea, that got me started in the first place.

Originally Posted by InsaneWallaby

Also, good with the tradeskilling difficulty being changed according to skill. Brewing, for instance, was always much harder to put up than something like jewelcraft, if I remember from my five years ago properly.

There was an tradeskill revamp in 2005. See http://mboards.eqtraders.com/eq/showthread.php?t=22246
Brewing is a bit easier than Jewelcraft, but not as easy as Smithing.

@fathernitwit: How about raising the r_value for tradeskills in zone/maxskill.h to 300?

Right now I am thinking about some scripts to grab and import all known recipes from eqtraders.com.

[eq4me]

@fathernitwit: How about raising the r_value for tradeskills in zone/maxskill.h to 300?

To answer my own question:

Probably not without some changes to part of the code or even the database, if its an int8 value too.

Eg. zone/client.cpp

void Client::SetSkill(int skillid, int8 value) {
        if (skillid > HIGHEST_SKILL)
                return;
        m_pp.skills[skillid] = value; // We need to be able to #setskill 254 and 255 to reset skills

        if(value <= 252) {
                EQApplicationPacket* outapp = new EQApplicationPacket(OP_SkillUpdate, sizeof(SkillUpdate_Struct));
                SkillUpdate_Struct* skill = (SkillUpdate_Struct*)outapp->pBuffer;
                skill->skillId=skillid;
                skill->value=value;
                QueuePacket(outapp);
                safe_delete(outapp);
        }

[fathernitwit]

I will look over this and try to get it in some time soon.

Its not likely to be a small amount of work to support skills over 252, since so much of the code and DB treat 253-255 as special values.. but your welcome to try.

Originally Posted by eq4me

Right now I am thinking about some scripts to grab and import all known recipes from eqtraders.com.

Where do you think all the recipes we have came from? I havent run it in several months, but most new recipes dont really apply anyhow.

[fathernitwit]

Have a look over what I checked in. I rewrote some of it (success min/max) since it still didnt look right. Let me know how it works out, I havent tested it.

A couple comments:
- use the log system to do conditional logging, not ifdef'd messages
- never cast unless you have very good reason to do so, it all too often masks or creates bugs.

[eq4me]

Yea, that looks better than my attempt.

Btw. The "Checking Out A Branch From CVS On UNIX" in the Wiki might not be quite right.
At least I get an "connect to cvs.sourceforge.net(66.35.250.207):2401 failed: No route to host" right now

cvs -d:pserver:anonymous@eqemulator.cvs.sourceforge.net:/cvsroot/eqemulator login
cvs -z3 -d:pserver:anonymous@eqemulator.cvs.sourceforge.net:/cvsroot/eqemulator co -r Development -P EQEmuCVS

works.

Where do you think all the recipes we have came from? I havent run it in several months, but most new recipes dont really apply anyhow.

I dont have time to check this right now but I was under the impression that there are quite some working recipes missing that where available in cavedudes database. I have a look when I get home from work.

[fathernitwit]

Originally Posted by eq4me

Btw. The "Checking Out A Branch From CVS On UNIX" in the Wiki might not be quite right.

its a wiki, just fix it.