Corpses and Junk

**fathernitwit** · #1 10-15-2006, 10:32 AM

hey,nice work. here are my quickly scribed comments as I was merging it in:

Please ignore whitespace when making your diffs.

When adjusting hard coded constants in the code, like exp loss level or pet range, please replace the constants with the rule system instead (placing your value as the default), so people can tune it as they see fit.

as for your pet thing, the DistNoZ returns an absolute distance, not a squared, so you increased the range to 10000. I changed this to 150.

what is this about? did you mean to send out app3 instead of app2 2 lines down?

Code:

+                       EQApplicationPacket app3;
+                       CreateSpawnPacket(&app3, new_corpse);

as for:

Code:

+               AddCash(0,0,0,0);
+               //Add no money because otherwise the corpse tries to use
+               //Uninited Vars and you'll get random amounts of money from the naked corpse

its better to fix the problem (init them to 0 in constructor) than to do this.

**KLS** · #2 10-15-2006, 10:44 AM

I'm not sure on the createspawnpacket thing, all I know is it works and works well. I actually had written that part of it a while back so I don't remember the logic offhand when I wrote it.

I'm sorry about the diffs, I'm still new at making them, I've never really coded for much more than myself you see. And yeah I really should have fixed the problem and put the system in rules(had been considering it, see above).

Will take a look at the corpse packet thing and try to see wtf I was doing.

**KLS** · #3 10-15-2006, 10:58 AM

Looking at it I'm pretty sure it's just an artifact of something I tried to do in the earlier code that didn't get removed when I put it all together and I didn't catch it, sorry.