PHP Simple Item Editor

[gernblan]

This is great!

One thing I may report? You need to escape out single quotes, as some items have a ' in their name.

The way the editor is now, it breaks if you try to edit any item (or lore) with an apostrophe.

[sdabbs65]

Originally Posted by gernblan

This is great!

One thing I may report? You need to escape out single quotes, as some items have a ' in their name.

The way the editor is now, it breaks if you try to edit any item (or lore) with an apostrophe.

Treid it last night...seems it inserts above max_id and crashes the server
so you wantto watch what you duplacate for now.

[gernblan]

I'm referring to the fact that anything with an apostrophe needs an "escape" a \ before the ' to be read correctly.

The code is stripping them out (no logic to handle the escapes), which is cutting off anything in a name past the '

It's a show stopping bug because it can corrupt item names with an apostrophe in them.

[sdabbs65]

Originally Posted by gernblan

I'm referring to the fact that anything with an apostrophe needs an "escape" a \ before the ' to be read correctly.

The code is stripping them out (no logic to handle the escapes), which is cutting off anything in a name past the '

It's a show stopping bug because it can corrupt item names with an apostrophe in them.

Thats also a bug but it also inserts the new item above max_item_id 's limit.

[gernblan]

Originally Posted by sdabbs65

Thats also a bug but it also inserts the new item above max_item_id 's limit.

Ok, but since you quoted me I thought you were commenting on what I said specifically.

[Theeper]

This can be confusing sometimes if magic_quotes_gpc are enabled in PHP. This setting automagically escapes single and double quotes on POSTed data, but doesn't actually insert the escape characters into the DB. So, the data will post properly, but will need escaped when echoing into the form HTML.

On the other hand, if magic_quotes_gpc is off on your system, the single quotes might be breaking your insert query string, so the data isn't making it to the DB properly.

Either way, using double quotes to delimit your string values in the HTML form is an easy way to deal with single quotes. This is, of course if you don't plan on ever having strings that have double quotes in them. If you do, you could always do some str_replace()'s with ascii values for quotes.

[gernblan]

So yeah, until that is addressed and fixed I cannot recommend this excellent script to anyone.

...and that sucks.

I'd fix it, honest I would, if I only had time. I'm so buried in the upkeep of my own server and the other projects I've already taken on. :(

[gernblan]

See:

http://www.tizag.com/phpT/strings.php