Summoned Pets Turn to Ghosts

Breea · #1 09-08-2007, 06:02 PM

Here we go...

Code:

	if(tmp->GetOwnerID() != GetID()) {
		SetPetID(0);
		// WE NEED TO KILL THE PET HERE!!!!!
		return(NULL);
	}

I'm assuming adding a kill code here in pets.cpp will get the job done?

Would this work for instance?

Code:

	if(tmp->GetOwnerID() != GetID()) {
		SetPetID(0);
        // Attempting to remove shadow pet.
		depop();
		return(NULL);
	}

Not sure that depop() is registered in any global functions or not =S

Breea · #2 09-08-2007, 06:13 PM

Also if we can get the pets working adding the same to the mounts would be an easy fix.

Breea · #3 09-08-2007, 07:39 PM

I tried strait up Depop(); that crashed the zone server... should it be pet->Depop(); ??

**KLS** · #4 09-08-2007, 07:58 PM

How exactly can I reproduce this 100% of the time? Or does this only happen sometimes?

Breea · #5 09-08-2007, 08:50 PM

Quote:

Originally Posted by KLS

How exactly can I reproduce this 100% of the time? Or does this only happen sometimes?

It happens 100% of the time on a source build (last 5 releases) on a linux (fedora 6) quad-core box.

It is also adding these as npcs in the npc_types table.. Basically this could become a stability comprimise if a mage or pet class decides to just zone back and forth a few thousand times.

**KLS** · #6 09-09-2007, 06:14 AM

Hm well it doesn't happen here as described.

Player1 in zone with pet, player2 in same zone. Player1 zones out and pet disappears.

I'm not sure how or why it's getting added to your npc_types table. The only code that does that from stock emu code is command related...

Not sure what's going on but that doesn't sound good.

**KLS** · #7 09-10-2007, 05:45 PM

I'm still unable to replicate this, BUT.. if you're looking for a solution you could add something inside the npc::process tic_timer.check().

Code:

if(!IsCorpse() && GetPetType() != petCharmed)
{
     if(!GetOwner())
          Depop();
}

I'm not sure if it would work but it's worth a shot?

If we can figure out what causes this it'd be nice too.

Lalolyen · #8 09-10-2007, 07:41 PM

I'll be implementing that code asap. Also Breea should have sent you a PM there. Basically if you want to help us find out whats causing it, you have that open invitation.