Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Bug Reports

Development::Bug Reports Post detailed bug reports and what you would like to see next in the emu here.

Reply
 
Thread Tools Display Modes
  #1  
Old 10-20-2007, 06:38 AM
John Adams
Demi-God
 
Join Date: Jul 2006
Posts: 1,552
Default

I am not sure changing the varchar(30) to varchar(50) should effect performance (or it shouldn't really). I'd also guess the Emu doesn't really care what the name of the group is for anything important. spawngroup.name is supposed to only be a friendly name field, yes? The only place I really see it used is during the insert. I thought everything went off the spawngroupid?

But you could be onto something with truncating the name, and attempting to insert duplicate spawngroup.name data. Cuz "name" is Unique.
Reply With Quote
  #2  
Old 10-20-2007, 08:44 AM
cavedude's Avatar
cavedude
The PEQ Dude
 
Join Date: Apr 2003
Location: -
Posts: 1,988
Default

Quote:
Originally Posted by John Adams View Post
But you could be onto something with truncating the name, and attempting to insert duplicate spawngroup.name data. Cuz "name" is Unique.
I just encountered this same thing yesterday. The spawngroup wouldn't create because the spawngroup name was too long so identical names could not be created, only the first worked. Shortening the NPC's name, creating my groups, then changing it back worked perfectly.

Changing the column is a viable solution and it won't cause issues from a technical standpoint. But, that begs do the question do you really want names that long? Heh.
Reply With Quote
  #3  
Old 10-22-2007, 03:44 AM
gernblan
Discordant
 
Join Date: Aug 2006
Posts: 394
Default

Quote:
Originally Posted by John Adams View Post
I am not sure changing the varchar(30) to varchar(50) should effect performance (or it shouldn't really). I'd also guess the Emu doesn't really care what the name of the group is for anything important. spawngroup.name is supposed to only be a friendly name field, yes? The only place I really see it used is during the insert. I thought everything went off the spawngroupid?

But you could be onto something with truncating the name, and attempting to insert duplicate spawngroup.name data. Cuz "name" is Unique.
Well yes but if the insert fails because of the field length, it doesn't get in at all.

Thus, the mobs not showing up later.

So the emu may not care in practice what the name is when reading it... but it sure does care when creating the record in the first place.

Hence changing it to varchar(50).

It does solve thr problem.

And no I do not want the names that long, but what else can I do without adding a bunch of extra (tedious) steps?
__________________
--
Keelyeh
Owner, ServerOp and Developer
Jest 4 Server
Linux (Jest3 runs on Fedora, our Dev servers usually run on Ubuntu and/or Gentoo), OC-12 Connection = Hella Fast
Reply With Quote
  #4  
Old 10-22-2007, 03:46 AM
cavedude's Avatar
cavedude
The PEQ Dude
 
Join Date: Apr 2003
Location: -
Posts: 1,988
Default

Quote:
Originally Posted by gernblan View Post
Well yes but if the insert fails because of the field length, it doesn't get in at all.

Thus, the mobs not showing up later.

So the emu may not care in practice what the name is when reading it... but it sure does care when creating the record in the first place.

Hence changing it to varchar(50).

It does solve thr problem.

And no I do not want the names that long, but what else can I do without adding a bunch of extra (tedious) steps?
Agreed, I'm changing this column on PEQ.
Reply With Quote
  #5  
Old 10-23-2007, 01:54 AM
John Adams
Demi-God
 
Join Date: Jul 2006
Posts: 1,552
Default

Right, the emu is the one generating the hideously long names, not us. Maybe that random name generator needs a review? But the easy solution is to widen the field.

Thanks Cavedude. PEQdb is still my life blood.
Reply With Quote
  #6  
Old 10-23-2007, 12:48 PM
gernblan
Discordant
 
Join Date: Aug 2006
Posts: 394
Default

Glad to help
__________________
--
Keelyeh
Owner, ServerOp and Developer
Jest 4 Server
Linux (Jest3 runs on Fedora, our Dev servers usually run on Ubuntu and/or Gentoo), OC-12 Connection = Hella Fast
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 09:26 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3