Fix for tradskill bug

[WildcardX]

Unless this "fix" provides backwards compatibility to the existing 3500 recipes already in the database, I'm afraid we cant commit this to the server code. I don't see think breaking about 3500 recipes is worth the primary benefit of conserving some space in this table.

Either add in a way to provide backward compatibility or figure out a query to mass edit the existing recipes and then repost and I'll reconsider.

[Knightly]

or figure out a query to mass edit the existing recipes

Unfortunately, to do this you'd need every database to be consistent and they're not. Even within a single database (PEQ for example) there is very little consistency to the recipes because of how people currently read the information available on how to add a recipe.

The best I can do as far as that goes is to tell everyone HOW to change their existing database. Or (in the case of PEQ) post all of the changes to make it so that it is consistent enough to run queries against.

My actual plan is (once I finish PEQ) to post the code that I used to make the decisions on what to change. Right now, the code isn't perfect so I have to make a lot of tweaks manually. It has helped me find a lot of errors in the existing recipes, but it also creates a lot of errors. Of course, the more errors it creates, the more tweaks I can make until we're good. So far I've got fails and combines taken care of, but it doesn't work out successes very well (again, consistency due to the way that it looks like it should work vs how it acutally works and how people read it).

As I mentioned above, it's possible to write the backwards compatibility (and if you really really want me to, I will) but from my point of view it's easier to convert the existing databases than it is to write the backwards compatibility. And once I have the code finished for that I"ll post it for everyone.

[Knightly]

Bah, five minute rule. I also want to mention that changing the EQEmu code to take into account both cases will be messy for readability on the code. That's the main reason that I didn't recommend that method.

Also, my efforts in this area are not intended to reduce space in the table (it's a negligible reduction at best). I am more interested in making the databases consistent so that it's easier and more intuitive to add recipes.

[WildcardX]

It might not be as intuitive to add recipes, but this disadvantage can be mitigated through admin experience and tools designed to create recipes for the less experienced. I'd still prefer to keep the recipe system the way it is instead of implementing something that might be more intuitive but affects so many existing recipes.

Your welcome to keep pursing this issue and I'll be happy to reconsider a submitted viable solution, but maybe your time will be better spent on another issue thats more compelling.

OOC: Not trying to discourage you here.