NPC and loot editor - update2

moydock · #1 03-28-2008, 12:40 PM

Found a bug when creating a new lootdrop table. No row is added in "lootdrop", it just adds the row in "lootdrop_entries". This makes the entry not work, until you go in manually and create the row in lootdrop.

moydock · #2 03-28-2008, 12:59 PM

Also, if you go to Tools>Create new loottable, on an npc that has no loottable, you get the
Run-time error '3021': Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.

**GeorgeS** · #3 03-28-2008, 03:12 PM

You mean it crashes when there's a lootable=0?
I tried it and get no crash when I go tools/create new loottable_id
A new loottable gets added to where the 0 was.
I will check on the code ...

When I tried tools/create new lootdrop_id, a new id gets added with a rusty dagger as a loot item.

What works for you - is clicking on lootdrop_id - then seeing it added as a lootdrop (left panel) and an associated item in the right side panel?
But nothing happens with tools/create new loottable_id? - except a lootdrop_entries is created? weird.

I'm guessing it may be a integer vs. long variable declaration. I'm looking at it now..

GeorgeS

Can one else check this on their db?

ChaosSlayer · #4 03-28-2008, 03:20 PM

i think what he is referign to is following event:

do add loot table
the program ALWAYS add loottable #3 and item 7001
BUT if you type in NEW loot tabel id which does nto yet have any items in it - the editor will nto auto aa a generic item (7001) , and if you try to save that( wihotu addign SOEMTHING to the item table first) the editor will crash.

this is mroe of a fool prove feature, since you normaly do want to save a loottable which has nothgin in it =)

i ocasinaly click SAVE before I add an item casing a crash but over hours and hours I spent in the editor I learned to add item first and then save =)

**GeorgeS** · #5 03-28-2008, 04:50 PM

Yes, the item #3 is just a place holder to type a known lootdrop_id in.

So I went and re-wrote much of the code to be more robust in loottable id generation and lootdrops. I hope it responds better than before.

Crash with empty loottable=0 - cannot reproduce, and do not have vista...
See if this version makes a difference..

GeorgeS

Quote:

Originally Posted by ChaosSlayer

i think what he is referign to is following event:

do add loot table
the program ALWAYS add loottable #3 and item 7001
BUT if you type in NEW loot tabel id which does nto yet have any items in it - the editor will nto auto aa a generic item (7001) , and if you try to save that( wihotu addign SOEMTHING to the item table first) the editor will crash.

this is mroe of a fool prove feature, since you normaly do want to save a loottable which has nothgin in it =)

i ocasinaly click SAVE before I add an item casing a crash but over hours and hours I spent in the editor I learned to add item first and then save =)

moydock · #6 03-28-2008, 04:58 PM

Thanks George. Will do.

moydock · #7 03-28-2008, 05:13 PM

Still errors out. However more info: It's creating an entry in loottable, and loottable_entries, but the loottable_entries points to a lootdrop ID that it makes up, and doesn't exist. I'm thinking this could cause the error? Shouldn't it just create an entry in loottable? And then add the others as you choose to add them in?

Toriad · #8 04-24-2008, 05:08 AM

I'm trying to create a new npc using this but I keep gettiing invalid race/class ^_^

moydock · #9 03-28-2008, 03:45 PM

Quote:

Originally Posted by GeorgeS

You mean it crashes when there's a lootable=0?
I tried it and get no crash when I go tools/create new loottable_id
A new loottable gets added to where the 0 was.
I will check on the code ...

When I tried tools/create new lootdrop_id, a new id gets added with a rusty dagger as a loot item.

What works for you - is clicking on lootdrop_id - then seeing it added as a lootdrop (left panel) and an associated item in the right side panel?
But nothing happens with tools/create new loottable_id? - except a lootdrop_entries is created? weird.

I'm guessing it may be a integer vs. long variable declaration. I'm looking at it now..

GeorgeS

Can one else check this on their db?

For the first problem, everything functions properly, except afterwards you have to go into your database and manually create a new entry in lootdrop, that corresponds to the new ID your tool created in lootdrop_entries.

For the 2nd problem, I select an npc that has a completely blank loot entry, as in not even coin, and I go to Tools-> Create New Loottable_id and I get that error and crash.
I'm running windows vista.

ChaosSlayer · #10 03-28-2008, 03:51 PM

Quote:

Originally Posted by moydock

For the first problem, everything functions properly, except afterwards you have to go into your database and manually create a new entry in lootdrop, that corresponds to the new ID your tool created in lootdrop_entries.

ah rigth- you referign to a NAME of the loot table- yeah if that don't exist the tabel will nto work in game unless ist named/created.

Quote:

For the 2nd problem, I select an npc that has a completely blank loot entry, as in not even coin, and I go to Tools-> Create New Loottable_id and I get that error and crash.
I'm running windows vista.

i don't get such eror - could be Vista thing =)