Removing Non-Titanium Version Checks

[trevius]

Well, leaving 6.2 in is easy enough, but the order can easily still be changed so that it checks for 7.0 first, since that is by far the most common one used.

The code would look like this:

#include "../debug.h"
#include "patches.h"

#include "Titanium.h"
#include "Client62.h"
//#include "Anniversary.h"
//#include "Live.h"


void RegisterAllPatches(EQStreamIdentifier &into) {
	Titanium::Register(into);
	Client62::Register(into);
//	Anniversary::Register(into);
//	Live::Register(into);
}

void ReloadAllPatches() {
	Titanium::Reload();
	Client62::Reload();
//	Anniversary::Reload();
//	Live::Reload();
}

I can certainly understand leaving 6.2 in there for the few that still use it, but at this time I see little need for the Anniversary or Live checks.

So far, I have still noticed 0 issues with having this on my server. I haven't seen any noticeable performance increases either, but it is still too early to tell. I think this change combined with the fix for the "lag bug" may at least help reduce log file sizes as well as maybe a very slight decrease in bandwidth utilization.

[MNWatchdog]

Why not make it so it only does the check once upon logging in. People arent changing clients between zonings.

[trevius]

I think zoning and logging in are done in similar processes. So, they are looked at pretty much the same way. In order to do what you mentioned, I think the client version would have to be written into a table somewhere so it would be stored and referenced later. But, that wouldn't be good if for any reason people were switching client versions and trying to use the same account.

[KLS]

It already does the check only once and sticks the version used into the stream identifier and then uses that to decode and encode the data. It's not like we're doing a lookup on every packet that comes in, only on new connections.

[rojadruid]

Originally Posted by trevius

Well, leaving 6.2 in is easy enough, but the order can easily still be changed so that it checks for 7.0 first, since that is by far the most common one used.

I can certainly understand leaving 6.2 in there for the few that still use it, but at this time I see little need for the Anniversary or Live checks.

Anniversary was just recently added in the last 4 to 6 months by FNW. I thought/think that it was due to some one working on it but I could be wrong. Live checks are there for the future as it can be re-named as/if we ever catch up to it and then it get past.

[John Adams]

Originally Posted by rojadruid

Anniversary was just recently added in the last 4 to 6 months by FNW.

Heh, it's been a helluva lot longer than 6 mos though that is only important to those holding their breath for newer client support.