Wow GeorgeS! You have really outdone yourself this time
Nice work!
For an initial release with this much work required, it is already surprisingly close to perfect. Of course, I have a few notes that I wanted to mention that you may want to consider taking a look at.
I also wanted to mention that I too was having the problem with trying to set the icons crashing the program. But, that was easily resolved by running the Register_OCX.bat file that came with this version. Worth noting for anyone who has that issue.
And, I think that leaving the Line Editor is a good idea, because it has the bottom scroll area that lets players edit any of the random or unknown fields that are not included in the new editor. Though, it would probably be very rarely if ever used.
List of minor issues I have found so far:
1. I think it might be useful to adjust how slots are chosen a bit. If it is possible, it would be nice if you could make the drop down box for selecting slots to have check mark fields. This would let you easily select multiple slots. As it is currently, you can only see the first slot that is chosen and this includes the view from the new edit window as well as from the main window for the Item Editor Tool. It is important to see all slots that the item is set to in at least 1 of those 2 places. Also, Deities may need to be setup in a similar way if possible.
2. When I click on the button to select Click Effects, it opens a window, but doesn't automatically load the spell list. I assume you made it that way so you could add a partial name search field so people could load up only what they were looking for or still have the option to load the entire list. That would be useful. I also wanted to mention that after I did Load the Spell List, I click the name Column to sort by name and found that for some reason, it put a bunch of blank rows at the top of the list and I had to scroll down a bit to get to where the actual spell list starts. Not sure what is causing that.
3. In the notes for the Cast Times/Charges Guide, you might want to add a note about Recast Delay being in seconds, since it isn't mentioned there. This might help remove any confusion since the cast times are in milliseconds and Recast Delay is just full seconds.
4. I was pleased to see that using the TAB key to switch between edit fields works nicely. Though, when I got to the section with Accuracy, Shielding, etc, I noticed that hitting TAB caused it to jump around to different fields that were not in the order I thought it should have gone in. If possible, it would be nice to have those in an order. It would also be awesome if using the TAB key to switch fields would also cause the selected field to select the text inside so that you could start typing without having to delete the text currently in that field. The Augments section has this same jumping around issue as well.
5. While testing, I clicked the Bag Type button and saw that it changed the field to a drop down box. Though, the box didn't have a "None" listed in it to set it back to none. I don't think this is very important really, since most people wouldn't even click that unless they were actually wanting to make a bag.
That is all I have found so far. All of them are fairly minor issues and some are more preference than issues even. Pretty amazing for an initial release if you ask me
I also wanted to mention that if you would like some custom buttons made for your tool(s), just let me know and I will start working on a set. If you can give me samples of all the buttons you would like designed, I can use those for dimensions to make new ones that can replace them so there is no code editing required. I tried looking through the resource folder in the eqitems folder for the image files that are used for the current buttons, but I could only find other sets of buttons and not the exact set that is currently in use. Not sure where it is pulling them from exactly. If I can figure that out, then I can make a set and test them out and then send them to you.
Here are some examples from a button set I made fully custom for a forum I used to run (so you can get an idea of what I can do):
I am pretty decent with Photoshop, so if there are any other things you would like adjusted or made for your tools, let me know and I will make time to get them done.
Thanks again for all of your hard work, GeorgeS!
Hybrid Mode
