Combat Fixes

[bleh9]

Originally Posted by James76

I replaced any "x++" with "++x" for example, because its actually faster and you only need the post-increment on something like "myarray[x++]" which increments x after reading from the array, or "myarray[++x]" which increments x before reading from the array. Its faster because the post-increment has to push the value to return on the stack before incrementing.

Maybe I'm missing something, but myarray[x++] isn't the same as myarray[++x]. Also, ++x and x++ often optimized the same.

[James76]

Originally Posted by bleh9

Maybe I'm missing something, but myarray[x++] isn't the same as myarray[++x]. Also, ++x and x++ often compile to the same thing.

I said that you don't need x++ UNLESS you're using it on a line such as "myarray[...]" where it actually matters, where more than one segment is processed before the rest of the statement. I even defined what post-increment and pre-increment means. Why am I defending myself?

And assuming it will compile to the same thing is incorrect, it will only do so if the specific optimization flag is set on the gcc execution. Assuming anything is poor code, its always better to implement as intended.

[James76]

OK, the attack.cpp file replacement is ready. Just subtle changes throughout. The major change is damage bonus.... That monks get +20%, and at level 50 (and every five levels) you gain +15% damage. It looked like that's what was intended in the original source, but the math was screwing it up.

Here is it.

- Test the ripostes if you like, the discipline is Furious for warriors, at level 56.

- Combat damage significantly increased.. both for you and against you.. Lets see if its still balanced? Solo-raids should become more difficult.

I still have my database mobs ATK and Accuracy set to my last stated update based on level. I'd like people to test that and let me know if the code's defaults should be more on par with that, or find better generic values.. Maybe raid mobs should get 2x the values? You get the idea.

Enjoy the ripostes! They can trigger now on every attack instead of every hit.

[James76]

Anybody bring this in to their builds?

[renoofturks1]

I am hoping to test it tonight.

[James76]

These combat fixes were so important to the emulator, but they appear to be overlooked? There should also be an additional change, a riposte should beat an "automatic hit", since I recall a duel I had between my warrior and a ranger, he triggered auto hits, and I wielded the slowest 2H with the highest damage I found at that time, activated auto-riposte, and he died in seconds. So, is this still getting looked at? Is anybody using this? Seems like changes are like trying to move mountains. I'm just trying to shake things up and make everything better.

[Andrew80k]

I totally missed this. I will add it to my server tonight and start playing with it.