PC main and second hand attacks

[trevius]

It sounds like you have some nice fixes/adjustments in there. I don't remember enough about the exact working of Live to help verify some of the changes you made though.

Maybe the discussion in this post can help some.
http://www.eqemulator.net/forums/showthread.php?t=26099

I think most of your code sounds about right, but someone will need to confirm everything is pretty finalized before this could go into the source.

[cavedude]

I already moved the code part of this to submissions and stickied. So I guess, we'll take it from there.

[Congdar]

I made an error on the secondary hand... the check for increase in dual_wield skill needs to change. You can get a skill up even if you don't succeed in dual wielding so delete in red... add(leave it there) in blue:

				float random = MakeRandomFloat(0, 1);
				//if (random > 0.9)	//this dosent make sense...
				CheckIncreaseSkill(DUAL_WIELD);
				if (random < DualWieldProbability  || GetAA(aaAmbidexterity)) { // Max 78% of DW
					if(CheckAAEffect(aaEffectRampage)) {
						entity_list.AEAttack(this, 30, 14);
					} else {
						Attack(target, 14);	// Single attack with offhand
					}
					CheckIncreaseSkill(DUAL_WIELD);
					
					if( CanThisClassDoubleAttack() && CheckDoubleAttack()) {

This code change results in added flurry bonus for main hand for Raging Fury AA only on successful tripple attack as described in the AA text and removes 100% dual wield if you have Ambidexterity AA and instead using the bonus and calucuation, and removes flurry attacks from the secondary hand. If secondary is supposed to flurry (i don't think it does) or if secondary is supposed to get tripple attack then somebody needs to speak up. It also removes double skillup in dual wield.

[Congdar]

GetSkill() and GetRawSkill(). Don't change it to GetRawSkill(). It seems that

itembonuses.skillmod[DUAL_WIELD]

checks from a different place than

itembonuses.DualWeildChance

I think the second way may be for Tribute but doesn't currently add the bonus in there. Disciplines for Rogue and Bard do work in spellbonuses.DualWeildChance, so not sure if it's redundant or ?