Double Attack change

[AndMetal]

Originally Posted by Congdar

        // If your chance is greater than the RNG you are successful!
	if(chance > MakeRandomInt(0, maxSkill*.92)) {
		return true;
	}

Just to make sure I'm understanding correctly, that means the last 8% of skill-ups before the max cap would always land, since chance will equal at least the skill level of the character, not including any mods, right?

If that's the case, I think we may want to rethink this, especially in the scenario of newer levels. For example, a Monk on a progression server levels up to 50, so their max skill would be 240, so they would start double attacking 100% of the time after 220.8 (so starting at 221) skill. Say the player stops playing & the level cap has been raised to 65 (PoP I think?). They may have 240 skill, but the minimum to double attack 100% of the time (max being 265) is now 243.8 (so have to have 244+). The character hasn't changed, the rules of the server haven't changed, just the max level, but they won't be hitting like before. Granted, in that scenario, it's only a difference of about 9.5%, but that can still be significant.

Imo, I think it should be a static value, possibly set as a Rule. If it was set as a rule, would allow us to have a default value, similar to Live (which 300 sounds about right), but if you want to tune it for Progression-type servers, etc, you can.

Thoughts?