Veteran's Wrath AA

[AndMetal]

My apologies. I blame the lack of sleep. This should fix it (and I'll update to SVN):

In zone/attack.cpp around line 3157, change

			//Veteran's Wrath AA
			//first, make sure it's not a special attack
			if (skill == _1H_BLUNT
				|| skill == _2H_BLUNT
				|| skill == _1H_SLASHING
				|| skill == _2H_SLASHING
				|| skill == PIERCING
				|| skill == HAND_TO_HAND
				/*|| skill == ARCHERY*/ //AndMetal: not sure if we should be giving this to rangers
				)
				damage *= GetAA(aaVeteransWrath) * 15; //AndMetal: guessing

to

			//Veteran's Wrath AA
			//first, find out of we have it (don't multiply by 0 :-\ )
			int32 AAdmgmod = GetAA(aaVeteransWrath);
			if (AAdmgmod > 0) {
				//now, make sure it's not a special attack
				if (skill == _1H_BLUNT
					|| skill == _2H_BLUNT
					|| skill == _1H_SLASHING
					|| skill == _2H_SLASHING
					|| skill == PIERCING
					|| skill == HAND_TO_HAND
					/*|| skill == ARCHERY*/ //AndMetal: not sure if we should be giving this to rangers
					)
					damage *= (AAdmgmod) * 15) / 100; //AndMetal: guessing
			}

[trevius]

That fix looks better I will probably try it out tonight and see how it goes. I am not sure what the actual equation to calculate the bonus from the AA is doing though. But, I do know that with it being set to just * 15, it was causing hits for 25k from bards and up to like 75k from SKs lol.

I think it has an extra parenthesis that is marked in red below:

damage *= (AAdmgmod) * 15) / 100; //AndMetal: guessing

So, when it gets the AA (GetAA(aaVeteransWrath)), it is just getting the number of how many points they have in it, correct? So, if they have 1 point trained, your equation would look like:

damage *= (1 * 15) / 100; // Total equals 0.15

And if they have 5 points trained in the AA, the equation would be:

damage *= (5 * 15) / 100; // Total equals 0.75

And, if I am correct in thinking this, does that mean it is going to multiply all damage by the total amount that I noted in the comments there? Will that replace the critmod multiplier here?:

damage = (damage * critMod) / 100;

Or is it supposed to add to it? I am not exactly clear on understanding this as you can see But, if you multiply anything by less than 1, you would be reducing damage instead of increasing it. I am probably totally wrong in understanding what this is doing though, lol. I don't even know what *= does, I am just assuming it means "multiplier equals" or something.

[AndMetal]

Wow, I feel really special... Keep forgetting that you have to add 1.

			//Veteran's Wrath AA
			//first, find out of we have it (don't multiply by 0 :-\ )
			int32 AAdmgmod = GetAA(aaVeteransWrath);
			if (AAdmgmod > 0) {
				//now, make sure it's not a special attack
				if (skill == _1H_BLUNT
					|| skill == _2H_BLUNT
					|| skill == _1H_SLASHING
					|| skill == _2H_SLASHING
					|| skill == PIERCING
					|| skill == HAND_TO_HAND
					/*|| skill == ARCHERY*/ //AndMetal: not sure if we should be giving this to rangers
					)
					damage *= ((AAdmgmod * 15) / 100) + 100; //AndMetal: guessing
			}

[trevius]

After discussing this with AndMetal, I think we both came to a solution that should probably finalize this AA. I will test this code out tonight, but I think it looks like the best way to do it:

//Veteran's Wrath AA
//first, find out of we have it (don't multiply by 0 :-\ )
int32 AAdmgmod = GetAA(aaVeteransWrath);
if (AAdmgmod > 0) {
//now, make sure it's not a special attack
if (skill == _1H_BLUNT
|| skill == _2H_BLUNT
|| skill == _1H_SLASHING
|| skill == _2H_SLASHING
|| skill == PIERCING
|| skill == HAND_TO_HAND
/*|| skill == ARCHERY*/ //AndMetal: not sure if we should be giving this to rangers
)
critMod += AAdmgmod * 3; //AndMetal: guessing
}

damage = (damage * critMod) / 100;

[KLS]

Can someone explain what this aa is supposed to do?

[trevius]

Not at home to read the actual AA message, but from what AndMetal told me, I believe it is supposed to increase crit damage for non-special attacks.

In this case, we have it set to add 3% damage per train level of the AA, so a total of +15% max. So, if critmod is 200, then this would make it 215 (max). Nothing too overpowering, but a decent little boost in non-special attack crits.

[KLS]

Ah, I was looking at what was committed and going: what the hell are they trying to accomplish?

This can be done pretty easily.