OOC Regen Enable/Disable

[trevius]

Added another rule to the code to allow admins to chose if they want player casting to stop OOC Regen or not. This will stop OOC regen if a player is casting buffs or a nuke or anything else.

Once the engaged check is working, this system should be pretty robust lol.

[ChaosSlayer]

so what was wrong with using Feign Death like approach? or does FD simply erased hate lists?

[trevius]

That FD check was in the Bots code and it has since been removed and replaced. It was actually checking if they were FD or if they were engaged before it would allow a bot to be summoned. Apparently the IsEngaged check has been changed so that it doesn't work for players anymore. I am not sure why.

[AndMetal]

For some reason I thought something was changed with the client hate list, but I may have misread something (discussion), because I can't find it being mentioned specifically (or in the changelogs, etc).

Looking through the code, Mob::IsEngaged checks to see if the hate_list, tucked in the protected portion of the Mob class in zone/mob.h, IsEmpty() (defined in hate_list.cpp). At that point, it basically iterates through the hate list to see if there are any hate values > -1.

There is a function, Mob::PrintHateListToClient (which basically points to HateList::PrintToClient) that's used by the #hatelist command that we might be able to use to debug it. I'm still running the base version of 1129, and I'm able to see my (client) hate list fine.

On a somewhat related note, the current SVN source doesn't wipe the client's hate list after you have successfully feigned and then waited the 2 min for the aggro to clear, at least as far as I can tell. As a result, you could still be considered Engaged if a mob you were killing is still alive, you feigned, & its hate list is wiped, so it no longer knows about you. You should be able to do this:
in zone/client_process.cpp, around line 626, add

	// EverHood Feign Death 2 minutes and zone forgets you
	if (forget_timer.Check()) {
		forget_timer.Disable();
		entity_list.ClearZoneFeignAggro(this);
		WhipeHateList(); //wipe the client's hate list
		Message(0,"Your enemies have forgotten you!");
	}

I'm pretty sure WhipeHateList (sic) should be able to inherit from the Mob class, although if not, we may need to rework it a little.

In any case, if anyone has a chance to check the client/bot hate lists to see what's going on, maybe we can get to the bottom of this.

[So_1337]

I'm still running the base version of 1129, and I'm able to see my (client) hate list fine.

The change came in Revision 38:

==10/03/2008
KLS: Hate list will no longer work for non ai controlloed player characters.

The problem had been that the client was maintaining a hate list that would never be wiped unless the mob on it was killed or the player camped/zoned. This was what was causing feign death to pull zone-wide trains. Since removing the hatelist from players, it's been corrected, though it has had other issues (such as breaking the mob fleeing code; they originally checked the client hatelist to see if there were other mobs with them).

My guess is that that may be what IsEngaged was calling on, and it's no longer there.

[Congdar]

attack.cpp Mob::AddToHateList

	if(IsClient() && !IsAIControlled())
		return;

This is where the hate_list is used for the client... only if the client is charmed and aicontrolled.

[trevius]

I think we can set IsEngaged() back to the way it was before and simply add in the whipehatelist code that AndMetal posted to fix the FD issue. The IsEngaged() check being available for clients is just too useful to remove it to fix FD. I am pretty sure that the fix AndMetal posted above will correct it. I will try it out tonight along with my OOC Regen code using the old IsEngaged() check by removing the check that Congdar posted. I think that will resolve some of the issues we are having right now with other code.