Wrong Section? Merchant's Items Mislabeled?

[cavedude]

Yeah, this one is known and has been around forever. Reordering the items so they are in order by slotid corrects the problem. The items should be in order anyway, so I kinda like this bug. It lets me know when a merchant is out of order instead of going to each individually.

I am noticing a trend here, please post bugs in either PEQ or EQEmu, not both. They are going to be seen by the same people anyway so it just adds confusion.

[ChaosSlayer]

Originally Posted by cavedude

Yeah, this one is known and has been around forever. Reordering the items so they are in order by slotid corrects the problem. The items should be in order anyway, so I kinda like this bug. It lets me know when a merchant is out of order instead of going to each individually.

I am noticing a trend here, please post bugs in either PEQ or EQEmu, not both. They are going to be seen by the same people anyway so it just adds confusion.

cavedude - could you be a little bit more specific how to "reorder" them?
or even better how to prevent this from happening?

thanks =)

[cavedude]

The slot column in merchantlist on a given merchant has to be in order, with no gaps. If you have a have items in slots 1, 2, 3, and 5 let's say what happens is if a player sells an item to that merchant it uses the first available slot. In this case 4. The problem arises when the next player sells an item to the merchant. It'll go in slot 5, even though an item already exists there because the server knows 4 is home to a player sold item, via merchantlist_temp.

The code should probe merchantlist before assigning a slot to merchantlist_temp to make sure it isn't already in use. That will correct the issue. However, since the slots should be in order anyway that's a moot point.

[trevius]

It sounds like you are right that it should be checking the merchantlist again before adding anything to merchantlist_temp. Even though it is probably best to fix every merchant so they are in order, I don't think it would be a bad idea to have it run that check of the merchantlist table again. Mainly I am thinking about servers running custom databases. Making sure all merchant tables are perfect could probably be a bit of a pain and it would be nice if people didn't have to.

[Angelox]

Agreed, that's a headache for me (renumbering everything), although I did start to do this, but quit, because I didn't see any need for it. I guess there is now.
there's got to be script that can be made to run and renumber them.

Originally Posted by trevius

It sounds like you are right that it should be checking the merchantlist again before adding anything to merchantlist_temp. Even though it is probably best to fix every merchant so they are in order, I don't think it would be a bad idea to have it run that check of the merchantlist table again. Mainly I am thinking about servers running custom databases. Making sure all merchant tables are perfect could probably be a bit of a pain and it would be nice if people didn't have to.

[GeorgeS]

Adding this to the merchant editor so gaps are removed is trivial. I'll add this as an option in tonight.


GeorgeS

[ChaosSlayer]

I still don't understand why we looking into how to "reorder" out of order merchants instead of fixing the source code to prevent the problem from occruing over and over again over time.