What's wrong with this quest?

[Derision]

You are missing a ; after each occurrence of quest::selfcast

[Randymarsh9]

thank you, that's what I get for copy/pasting.

[Justsomeguy]

hashes are now used instead of the old $porter restricted vars. Consider using $qglobals{porter} as the old method is deprecated. Using the new way does not require you to use all of the $porter = undef; as there are many potential errors when using that.

example:

 if ($qglobals{porter} >= 50) {

[Randymarsh9]

Ok, I have a new problem. I am trying to make a quest that checks the persons class. I have tried all formats I can think of and it will not check the class properly. Right now it is just an extremely simple quest because I am trying to figure out what's wrong with it. Knowing me, I probably just have something out of order.

sub EVENT_SAY{
 if ($text=~/hail/i){
  if ($class == "shadowknight"){
  quest::say("Hello.");
  }
 }
}

For the class I have also tried
if ($class = "shadowknight"){
if ($class = 'shadowknight'){
if ($class == 'shadowknight'){
if ($class eq "shadowknight"){
if ($class eq 'shadowknight'){

[Andrew80k]

Have you tried $class eq "Shadowknight" ? I think they are capitalized.

[Randymarsh9]

Nice, that fixed it. Thanks

[Randymarsh9]

New problem. I am trying to make a monster spawn adds at 75% and 25% and on death, but the only time one spawns is on death. This is the monsters quest

sub EVENT_SPAWN{
 quest::attacknpctype(1211);
}

sub EVENT_HP{
if ($hpevent <=75){
 quest::spawn(1210,0,0,76,11,0.50);
}
 if ($hpevent <=25){
 quest::spawn(1210,0,0,76,11,0.50);
}
}
sub EVENT_DEATH{
quest::spawn(1209,0,0,76,11,0.50);
}

[Thovar]

Originally Posted by Derision

You are missing a ; after each occurrence of quest::selfcast

Funny how this solved my problem and didn't realize this WAS the problem I was having. when I saw this posted I looked through my quest I was having an issue with and i as well was missing that silly little ; at the end of one of my many lines in this quest, and all along I thought I had a more complicated problem. ROFL... silly Monday details.