Should a quest NPC hand money back ?

[Shendare]

Yeah, my quest NPCs use a function similar to check_handin() that checks coins given, disregarding actual denominations used, and then they return unneeded extra coinage to the player as change as part of an upgraded return_items().

[cavedude]

Originally Posted by Shendare

Yeah, my quest NPCs use a function similar to check_handin() that checks coins given, disregarding actual denominations used, and then they return unneeded extra coinage to the player as change as part of an upgraded return_items().

Would you mind sharing that so I can add it to the PEQ repo?

[Shendare]

Yeah, I've been meaning to flesh it out, but I can post what I've got as soon as I do some cleanup.

[trevius]

I just started adding in a simple check to NPCs that take money like this:

sub EVENT_ITEM {

	if($platinum == 10)
	{
		quest::summonitem(1001);
		$platinum = undef;
	}
	else
	{
		if($platinum) {
			$client->AddMoneyToPP(0, 0, 0, $platinum, updateclient);
			quest::say ("That is not the required amount!");
			$platinum = undef;
		}
	}

}

Works well and is simple enough.

[ChaosSlayerZ]

hmm Trev, does all measurment done in "copper" ?

for example npc wants "10" - I assume 10 in copper?
so player can give npc 1 silver or 10 copper and both will work?

if yes - then you have just solved entire cash return problem

[trevius]

No, each coin type has it's own variable. If you want to be able to use all coin types, you could do this:

sub EVENT_ITEM {


	if($platinum == 10 || $gold == 100 || $silver == 1000 || $copper == 10000)
	{
		quest::summonitem(1001);
		$platinum = undef;
		$gold = undef;
		$silver = undef;
		$copper = undef;
	}
	else
	{
		if($platinum || $gold  || $silver || $copper) {
			$client->AddMoneyToPP($copper, $silver, $gold, $platinum, updateclient);
			quest::say ("That is not the required amount!");
			$platinum = undef;
			$gold = undef;
			$silver = undef;
			$copper = undef;
		}
	}

}

I haven't tested that yet, but it should work fine I think.

[ChaosSlayerZ]

I see, I can try this out
but it would be MUCH easier if it would have read value of ANY coins given as "copper"