Random Duration Invisibility:

nilbog · #1 10-05-2009, 04:06 PM

All the credit for this comes from Ladoth, from project 1999, not myself :o
Here is how we have it set up. Still more work to be done when we hit kunark.. because there are full duration invisibilities, but I hope this helps you out!

around line 100 in spdat.cpp

Code:

///////////////////////////////////////////////////////////////////////////////
// spell property testing functions

// @LADOTH 07182009 Is invis type spell
bool IsInvisibilitySpell(int16 spell_id)
{
	bool bResult = false;

	if( IsValidSpell(spell_id) && 
		(IsEffectInSpell(spell_id, SE_Invisibility) ||
		 IsEffectInSpell(spell_id, SE_Invisibility2) ||
		 IsEffectInSpell(spell_id, SE_InvisVsAnimals) ||
		 IsEffectInSpell(spell_id, SE_InvisVsUndead) ||
		 IsEffectInSpell(spell_id, SE_InvisVsUndead2))
		 )
	{
		bResult = true;
	}

	return bResult;
}

around line 610 of spdat.h

Code:

#endif
// @LADOTH 07182009 Is invis type spell
bool IsInvisibilitySpell(int16 spell_id);
bool IsTargetableAESpell(int16 spell_id);

around line 500 in spell_effects.cpp

Code:

#ifdef SPELL_EFFECT_SPAM
				snprintf(effect_desc, _EDLEN, "Invisibility");
#endif
				// solar: TODO already invis message and spell kill from SpellOnTarget
				SetInvisible(true);
				// @LADOTH 07252009 randomize time remaining for invis type spell
				float randscale = MakeRandomInt(1, 100) / 100.0f;
				buffs[buffslot].ticsremaining *= randscale;

around line 520 in spell_effects.cpp

Code:

#ifdef SPELL_EFFECT_SPAM
				snprintf(effect_desc, _EDLEN, "Invisibility to Animals");
#endif

				// @LADOTH 07252009 randomize time remaining for invis type spell
				float randscale = MakeRandomInt(1, 100) / 100.0f;
				buffs[buffslot].ticsremaining *= randscale;

around line 540 in spell_effects.cpp

Code:

#ifdef SPELL_EFFECT_SPAM
				snprintf(effect_desc, _EDLEN, "Invisibility to Undead");
#endif
				// @LADOTH 07252009 randomize time remaining for invis type spell
				float randscale = MakeRandomInt(1, 100) / 100.0f;
				buffs[buffslot].ticsremaining *= randscale;

**KLS** · #2 10-05-2009, 04:19 PM

Honestly you were overthinking it just a bit.

Easiest and most accurate implementation:

on tic if tics > 2 then a % chance to reduce tics to 2 and update buffduration client side.

So_1337 · #3 10-05-2009, 04:30 PM

Is that reply to Ladoth's code, or to Null's variation that I've been working on, KLS? If in regards to Null's, I actually liked that casting skill level (comparative to the skill cap) played a role in his version, and he also included the various "You feel yourself starting to appear" messages for the different invisibility types and gave two tics from that point before it faded. The only part I disagreed with was that he'd had them yellow originally (message type 15), and I seem to remember them being red.

However, this was all commented out of the TZVZ code as "needs work", and Ladoth seems to have a working version active on Project 1999. Working beats non-working any day =)

Either way, thanks for looking over this, KLS, and thanks for the alternate idea, backwards goblin. I do intend to keep hammering away at this, and all of these ideas really help.

**KLS** · #4 10-05-2009, 05:12 PM

The first mostly, the 2nd implementation has it's own problems as well.

**KLS** · #5 10-06-2009, 02:39 AM

Hopefully you don't mind that I sorta hijacked this too much. Should be implemented tonight though.

So_1337 · #6 10-06-2009, 08:17 AM

Haha, not at all. I know you're very skilled and spread too thin, so if anything, thank you for taking time away from your other projects to check this out. I'll pull the latest code and give it a look, I'm sure I can learn a lot from it.

Besides, you have pretty high standards for what goes in (as well you should, same as anyone else who contributes). I'd much rather save my first true submission for when I can give a diff for something better than a hack job =P And don't take that as any insult to Null's code, it's self-directed, haha.